Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

orte/mpirun: disable -debug option #905

Merged
merged 1 commit into from
Jan 22, 2016
Merged

orte/mpirun: disable -debug option #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions orte/tools/orterun/help-orterun.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,3 +660,10 @@ method and try launching your job again.

Your job will now abort.
#
[no_debugger_launch_support]
This version of Open MPI is known to have a problem using the "--debug"
option to mpirun, and has therefore disabled it. This functionality will
be restored in a future version of Open MPI.

Please see https://github.com/open-mpi/ompi/issues/1225 for details.

9 changes: 9 additions & 0 deletions orte/tools/orterun/orterun.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,7 +1147,16 @@ static int parse_globals(int argc, char* argv[], opal_cmd_line_t *cmd_line)
/* Do we want a user-level debugger? */

if (orterun_globals.debugger) {
#if 0
/* see https://github.com/open-mpi/ompi/issues/1225
* Once things are fixed, the orte_show_help/exit can be removed
* and this code re-enabled.
*/
run_debugger(orte_basename, cmd_line, argc, argv, orterun_globals.num_procs);
#else
orte_show_help("help-orterun.txt", "no_debugger_launch_support", false);
Copy link
Member

@jsquyres jsquyres Jan 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should #if 0 out the call to run_debugger() with a big comment explaining how we anticipate this to be temporary, and a pointer to the https URL for open-mpi/ompi#1225, and how the #if 0/#else/#endif should be removed once open-mpi/ompi#1225 is fixed...?

I say this because the call to run_debugger() is not incorrect, and when someone finally fixes this issue, they'll undoubtedly have to look up what the Right Thing is to put back instead of orte_show_help().

exit(-1);
#endif
}

/* if recovery was disabled on the cmd line, do so */
Expand Down