Skip to content

Some ompio code cleanup and reoarganization #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2016
Merged

Some ompio code cleanup and reoarganization #1851

merged 2 commits into from
Jul 18, 2016

Conversation

@edgargabriel
Copy link
Member

No description provided.

@lanl-ompi
Copy link
Contributor

Test FAILed.

1 similar comment
@lanl-ompi
Copy link
Contributor

Test FAILed.

@edgargabriel edgargabriel force-pushed the pr/ompio-reorg branch 2 times, most recently from de8d687 to 63d959f Compare July 6, 2016 21:21
@edgargabriel
Copy link
Member Author

I don't think the failure in the Mellanox build has anything to do with the code that I changed. I will rerun the tests in a couple of days, didn't plan to merge this commit before the 2.0 release anyway.

@jladd-mlnx
Copy link
Member

@edgargabriel The failure is due to the ompi request refactor and not a result of your changes.

@hjelmn
Copy link
Member

hjelmn commented Jul 7, 2016 •
edited
Loading

@jladd-mlnx Nothing to do with the request refactor. As we have explained Mellanox Jenkins is binding all 16 threads to 2 cores. This can cause any of the thread tests 1.1 tests to run extremely slow. The tests are timing out. @artpol84 Is working on fixing the Mellanox Jenkins tests.

@artpol84
Copy link
Contributor

artpol84 commented Jul 7, 2016

bot:retest

@artpol84
Copy link
Contributor

artpol84 commented Jul 7, 2016

Seems like a failure with depcomp that was rising sometime in the past.

10:10:01 make[2]: Entering directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal'
10:10:01 make[2]: warning: -jN forced in submake: disabling jobserver mode.
10:10:01 make[2]: *** No rule to make target `../config/depcomp', needed by `distdir'.  Stop.
10:10:01 make[2]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace/opal'
10:10:01 make[1]: *** [distdir] Error 1
10:10:01 make[1]: Leaving directory `/scrap/jenkins/jenkins/jobs/gh-ompi-master-pr/workspace'
10:10:01 make: *** [dist] Error 2
10:10:01 Make dist failed.  Aborting

@artpol84
Copy link
Contributor

artpol84 commented Jul 7, 2016

bot:retest

@jsquyres
Copy link
Member

jsquyres commented Jul 7, 2016

@artpol84 Yeah, I don't think we've figured out the root cause on the periodic Mellanox depcomp issues. We discussed this on #1824 (comment) recently, where I noted that sometimes the Mellanox Jenkins complains that something else happened elsewhere on the system, and it fails to copy depcomp as part of the Autotools run. This implies that something else is happening on the server at the same time as the Jenkins build, and is affecting the Autotools run.

@edgargabriel
remove some unused code
1f1504e
@edgargabriel
fcoll/base: mv coll_array functionis to fcoll base
195ec89 
the coll_array functions are truly only used by the fcoll modules, so move
them to fcoll/base. There is currently one exception to that rule (number of aggreagtors
logic), but that function will be moved in a long term also to fcoll/base.
@lanl-ompi
Copy link
Contributor

Test FAILed.

@edgargabriel
Copy link
Member Author

bot:retest

@lanl-ompi
Copy link
Contributor

Test FAILed.

@edgargabriel
Copy link
Member Author

bot:retest

@edgargabriel edgargabriel merged commit 31b7be6 into open-mpi:master Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@edgargabriel @lanl-ompi @jladd-mlnx @hjelmn @artpol84 @jsquyres