mtl/ofi: add some more mca parameters #1871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hppritcha Sounds good to me. Are these options required by the gni provider? Are there any other modifications needed to make it work? |
| MCA_BASE_VAR_SCOPE_READONLY, | ||
| &av_type); | ||
|
|
||
| return OMPI_SUCCESS; |
There was a problem hiding this comment.
@hppritcha This is a good place to use the mca_base_var_enum class. You can let the variable system handle the conversion of string->int. You also get value checking for free.
|
@yburette these are not required by the GNI provider but testers requested them to allow for easier triaging of potential bugs. |
|
@hppritcha Fair enough! |
allow for toggling of both control/data progress models. allow for using FI_AV_TABLE or FI_AV_MAP for av type. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
topic/ofi_mtl_params
branch
from
bbef89d to
22c8743
Compare
|
@hjelmn take a look now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow for toggling of both control/data progress models.
allow for using FI_AV_TABLE or FI_AV_MAP for av type.
@yburette
Signed-off-by: Howard Pritchard howardp@lanl.gov