ompi/fortran: fix typos in request RMA bindings #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjelmn you might also want to credit Alfio Lazzaro for the report and Joost VandeVondele for the help analyzing this issue |
|
:bot:retest |
|
@ggouaillardet I have filed a help ticket with Travis about the OS X build issue. |
This commit fixes typos on the C side of the request-based RMA binding. We were not returning the request on success but on failure. Thanks to @alazzaro for reporting and @ggouaillardet, and @vondele for tracking this down. Fixes part of open-mpi#1869 Signed-off-by: Nathan Hjelm <hjelmn@me.com>
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes typos on the C side of the request-based RMA binding. We
were not returning the request on success but on failure. Thanks to
@ggouaillardet for tracking this down.
Fixes part of #1869
Signed-off-by: Nathan Hjelm hjelmn@me.com