mpif-externals.h: add missing MPI_AINT_ADD/MPI_AINT_DIFF #3399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPI_AINT_ADD and MPI_AINT_DIFF are functions and must be declared as externals with the proper return type. This is already done properly in the mpi and mpi_f08 modules; these declarations for these functions were only missing from mpif.h (i.e., mpif-externals.h). Thanks to Aboorva Devarajan (@AboorvaDevarajan) for the bug report. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
ggouaillardet
approved these changes
Apr 24, 2017
Member
|
bot:ompi:retest It looks like a permissions issue in Jenkins ate the build success for the new PR checker. Re-running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPI_AINT_ADDandMPI_AINT_DIFFare functions and must be declared as externals with the proper return type. This is already done properly in thempiandmpi_f08modules; these declarations for these functions were only missing frommpif.h(i.e.,mpif-externals.h).Thanks to Aboorva Devarajan (@AboorvaDevarajan) for the bug report.
Fixes #3395
Signed-off-by: Jeff Squyres jsquyres@cisco.com
@ggouaillardet If this is good, I'll make PRs for all the release branches. I'll also be adding corresponding tests in ompi-tests/ibm shortly.