Skip to content

v3.0.x: ompi/mpi: Fixes for mpi_type_create_f90_(real|complex) #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2017
Merged

v3.0.x: ompi/mpi: Fixes for mpi_type_create_f90_(real|complex) #3578

merged 2 commits into from
Jun 2, 2017

Conversation

@jjhursey
Copy link
Member

@jjhursey jjhursey commented May 25, 2017

jjhursey added 2 commits May 25, 2017 09:01
@jjhursey
ompi/mpi: Fix parameter order in mpi_type_create_f90_(real|complex)
12ea29e 
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
(cherry picked from commit 5e302f5)
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey
ompi/mpi: Fix MPI_UNDEFINED handling in mpi_type_create_f90_(real|com…
14f59c1 
…plex)

Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
(cherry picked from commit a5e9c35)
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey jjhursey added the bug label May 25, 2017
@jjhursey jjhursey added this to the v3.0.0 milestone May 25, 2017
@jjhursey jjhursey requested a review from bosilca May 25, 2017 14:06
@jsquyres jsquyres changed the title ompi/mpi: Fixes for mpi_type_create_f90_(real|complex) v3.0.x: ompi/mpi: Fixes for mpi_type_create_f90_(real|complex) May 25, 2017
@hppritcha
Copy link
Member

hppritcha commented May 25, 2017

was this a customer reported bug? I'm askng in the event I need to update the news for 2.0.3.

@jjhursey
Copy link
Member Author

jjhursey commented May 25, 2017

Our testing folks found this issue. I don't know if their test came from a customer or not.

It is probably worth noting in the NEWS since (if for some reason) they assumed the old, incorrect behavior then they will need to update their code.

@bwbarrett bwbarrett changed the base branch from v3.x to v3.0.x May 31, 2017 02:03
@jjhursey
Copy link
Member Author

jjhursey commented Jun 2, 2017

@bwbarrett This PR has been sitting out here for a while approved. Any reason why it hasn't been merged in yet? Once it's merged in then I can merge in the ompi-tests update to exercise this code in MTT.

@bwbarrett
Copy link
Member

bwbarrett commented Jun 2, 2017

@jjhursey because I suck at my job? :)

@bwbarrett bwbarrett merged commit 326e7ef into open-mpi:v3.0.x Jun 2, 2017
@jjhursey jjhursey deleted the fix/v3.x/type_create_f90-dt branch June 2, 2017 14:46
@jjhursey
Copy link
Member Author

jjhursey commented Jun 2, 2017

Thanks. No problem - I know that v3.0 is shipping soon and didn't want this to get missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bosilca bosilca bosilca approved these changes

Assignees

@bosilca bosilca

Labels

bug RM approved

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jjhursey @hppritcha @bwbarrett @bosilca