OSHMEM/CONFIGURE: Check for the presence of ibv_exp_reg_shared_mr. #4343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ The sshmem verbs component will disqualify itself if this verb isn't present on the build host. + In case where support was requested but not found, don't stop the build - continue without this component. Signed-off-by: Alina Sklarevich <alinas@mellanox.com> (cherry picked from commit 3008827)
Member
Author
|
@yosefe @jladd-mlnx Please review |
yosefe
approved these changes
Oct 15, 2017
Contributor
|
Errr....I believe this PR violates OMPI's standards. If a user specifically requests something and it isn't found, then we require that you abort the build. |
Member
Author
|
@rhc54 Thanks, I will fix this. |
In case where support was requested but not found, stop the build. Signed-off-by: Alina Sklarevich <alinas@mellanox.com> (cherry picked from commit c7f5d13)
Member
Author
rhc54
approved these changes
Oct 17, 2017
jsquyres
approved these changes
Oct 17, 2017
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
I can confirm that the previous abort-on-error behavior was restored.
Member
|
@bwbarrett Can someone please merge this so that we can cover it in our nightly MTT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
present on the build host.
build - continue without this component.
Signed-off-by: Alina Sklarevich alinas@mellanox.com
(cherry picked from commit 3008827)