Fix treematch topology assert #4644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
reviewed
Dec 20, 2017
Member
bwbarrett
left a comment
bwbarrett
left a comment
There was a problem hiding this comment.
This feels like it should be two commits, one for the output changes and one for the assert changes. It also would be awesome to have some documentation on what was broken and how you fixed it w.r.t the asserts.
Member
Author
|
argh, there were 2 commits and I squashed them ... Let me split them again then. |
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
In both cases we were comparing with the wrong size, it should be either the number of local processes or the number of nodes, and not the size of the communicator. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
topic/treematch
branch
from
2b916ce to
3845584
Compare
Member
Author
|
The fixes were isolated into a single commit. The redirection of the debug output to the OMPI infrastructure is now on its own commit. |
bwbarrett
approved these changes
Dec 20, 2017
Member
|
haha; thanks! |
gpaulsen
approved these changes
Dec 20, 2017
Member
|
@bosilca, want to merge these? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the root cause of #4303.
Force all output to use OMPI infrastructure.
Signed-off-by: George Bosilca bosilca@icl.utk.edu