v2.x: rcache/grdma: fix crash when part of a registration is unmapped #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue when a registration is created for a large region and then invalidated while part of it is in use. References open-mpi#4509 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 39d5988) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
jsquyres
changed the title
jsquyres
approved these changes
Jan 3, 2018
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
The code changes look ok to me, but I am definitely not an expert in this area of the code. It seems to have fixed the issue on master, though -- so: approved.
Member
|
@hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue when a registration is created for a large
region and then invalidated while part of it is in use.
References #4509
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
(cherry picked from commit 39d5988)
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov