osc/pt2pt: fix synchronization bugs #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fragment flush code tries to send the active fragment before sending any queued fragments. This could cause osc messages to arrive out-of-order at the target (bad). Ensure ordering by alway sending the active fragment after sending queued fragments. This commit also fixes a bug when a synchronization message (unlock, flush, complete) can not be packed at the end of an existing active fragment. In this case the source process will end up sending 1 more fragment than claimed in the synchronization message. To fix the issue a check has been added that fixes the fragment count if this situation is detected. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
Author
|
@rolfv Fixes the MTT hangs you were seeing. |
|
Sent from
|
Refer to this link for build results (access rights to CI server needed): |
hjelmn
added a commit
that referenced
this pull request
Apr 7, 2015
osc/pt2pt: fix synchronization bugs
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Nov 10, 2015
…be39 hint processing should not open files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fragment flush code tries to send the active fragment before
sending any queued fragments. This could cause osc messages to arrive
out-of-order at the target (bad). Ensure ordering by alway sending
the active fragment after sending queued fragments.
This commit also fixes a bug when a synchronization message (unlock,
flush, complete) can not be packed at the end of an existing active
fragment. In this case the source process will end up sending 1 more
fragment than claimed in the synchronization message. To fix the issue
a check has been added that fixes the fragment count if this situation
is detected.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov