oob ud: fixes and parameter adjustment

[nkogteva]

No description provided.

[jsquyres]

If this is intended to convey an error message to the end user (vs. an OMPI developer), opal_show_help() should be used instead.

Ditto for all the opal_output()'s in this PR.

[mellanox-github]

• Coverity found 911 errors for all: http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//ws/cov_build/all_449/output/errors/index.html
• Coverity found 5 errors for oshmem: http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//ws/cov_build/oshmem_449/output/errors/index.html
• Coverity found 2 errors for fca: http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//ws/cov_build/fca_449/output/errors/index.html
  
  Sent from GH.

[mellanox-github]

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/jenkins/job/gh-ompi-master-pr/449/
Test PASSed.

[nkogteva]

@jsquyres Since review of whole component is needed in order to replace all similar outputs I propose to use another one PR. Otherwise it would be difficult to see the difference between formal changes and real fixes in the same PR.

[jsquyres]

@nkogteva That would be fine, but then you should strip all the opal_output_verbose -> opal_output conversions from this PR. Specifically: it does not make sense to me to commit something that makes a situation worse with the rationale that it will be fixed in the future (because that inevitably does not happen). Even more specifically: it seems like this PR is two different things, anyway: some fixes and some opal_output_verbose->opal_output conversions. So strip those out and make a 2nd PR to comprehensively convert all opal_output*'s of errors into opal_show_helps.

[mellanox-github]

• Coverity found 911 errors for all: http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//ws/cov_build/all_453/output/errors/index.html
• Coverity found 5 errors for oshmem: http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//ws/cov_build/oshmem_453/output/errors/index.html
• Coverity found 2 errors for fca: http://bgate.mellanox.com:8888/jenkins/job/gh-ompi-master-pr//ws/cov_build/fca_453/output/errors/index.html
  
  Sent from GH.

[jsquyres]

@nkogteva Thank you!

[mellanox-github]

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/jenkins/job/gh-ompi-master-pr/453/
Test PASSed.

[mike-dubman]

👍