New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build user and host #5653

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@bmwiedemann
Contributor

bmwiedemann commented Sep 7, 2018

Allow to override build user and host, using the standard $USER and $HOSTNAME environment variables to make reproducible builds possible.
See https://reproducible-builds.org/ for why this is good.

This helps improve issue #3759

@ompiteam-bot

This comment has been minimized.

Show comment
Hide comment
@ompiteam-bot

ompiteam-bot Sep 7, 2018

Can one of the admins verify this patch?

ompiteam-bot commented Sep 7, 2018

Can one of the admins verify this patch?

bmwiedemann added some commits Sep 7, 2018

autogen: only set full_hostname once
to remove useless code duplication

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
Allow to override build user and host
using the standard $USER and $HOSTNAME environment variables
to make reproducible builds possible.
See https://reproducible-builds.org/ for why this is good.

This helps improve issue #3759

Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
@jsquyres

This comment has been minimized.

Show comment
Hide comment
@jsquyres

jsquyres Sep 7, 2018

Member

ok to test

Member

jsquyres commented Sep 7, 2018

ok to test

@jsquyres

This comment has been minimized.

Show comment
Hide comment
@jsquyres

jsquyres Sep 7, 2018

Member

Thanks for bringing this to our attention again; I admit it kinda fell off our radar. 😦

Are you looking for both this PR and #3779 to be merged? (it looks like that one kinda fell off the radar, too...)

Also, per the discussion in #3759, are you interested in an output line in ompi_info, something like "Reproducible build: yes|no"? (ompi_info is the tool users use to see information about the Open MPI installation)

Member

jsquyres commented Sep 7, 2018

Thanks for bringing this to our attention again; I admit it kinda fell off our radar. 😦

Are you looking for both this PR and #3779 to be merged? (it looks like that one kinda fell off the radar, too...)

Also, per the discussion in #3759, are you interested in an output line in ompi_info, something like "Reproducible build: yes|no"? (ompi_info is the tool users use to see information about the Open MPI installation)

@bmwiedemann

This comment has been minimized.

Show comment
Hide comment
@bmwiedemann

bmwiedemann Sep 8, 2018

Contributor

I'd say, this change perfectly complements #3779

We could use $SOURCE_DATE_EPOCH as an indicator for "Reproducible build: yes"
but I'd prefer if we could keep the code simple and use this patch as is
and to compensate, in our .spec file we do something like

export HOSTNAME=reproducible-SUSE-rpm-build

which should show up in ompi_info as well

Contributor

bmwiedemann commented Sep 8, 2018

I'd say, this change perfectly complements #3779

We could use $SOURCE_DATE_EPOCH as an indicator for "Reproducible build: yes"
but I'd prefer if we could keep the code simple and use this patch as is
and to compensate, in our .spec file we do something like

export HOSTNAME=reproducible-SUSE-rpm-build

which should show up in ompi_info as well

@jsquyres

This comment has been minimized.

Show comment
Hide comment
@jsquyres

jsquyres Sep 11, 2018

Member

I'm good with this PR. Mind if I add a commit to it with a short README blurb about setting$USER and/or $HOSTNAME and citing Reproducible Builds? (what's the best URL to cite for RB's, anyway -- https://reproducible-builds.org/ ?)

Member

jsquyres commented Sep 11, 2018

I'm good with this PR. Mind if I add a commit to it with a short README blurb about setting$USER and/or $HOSTNAME and citing Reproducible Builds? (what's the best URL to cite for RB's, anyway -- https://reproducible-builds.org/ ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment