Fix macro return value when not CUDA-aware #811
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ompi/mpiext/cuda/configure.m4
Outdated
Member
There was a problem hiding this comment.
You should put $CUDA_SUPPORT in brackets, i.e., [$CUDA_SUPPORT].
Member
|
Other than those 2 minor comments, looks good. |
rolfv
force-pushed
the
pr/fix-cuda-ext-again
branch
from
c37b1a8 to
0e87478
Compare
Author
|
Fixed those two issues. Will wait for more testing before merging. |
Author
|
bot:retest |
rolfv
pushed a commit
that referenced
this pull request
Aug 14, 2015
Fix macro return value when not CUDA-aware
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
pml/ob1: add missing ompi_request_wait_completion for buffered sends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix things so we set the macro to 0 when no CUDA-aware. Otherwise, the macro is always set to 1 which is obviously wrong.
@jsquyres can you look at this one?
I still may try and change it so things are undefined, but that is still under discussion and I would like it to at least work as it was originally intended.