configury: make build reproducible #8136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
jsquyres
reviewed
Oct 26, 2020
This code was invoked twice. Leave it solely in OPAL_CONFIGURE_SETUP, which is invoked before OPAL_BASIC_SETUP. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
|
@bmwiedemann I took the liberty of pushing to this branch:
It seems to work. Can you confirm? |
bmwiedemann
commented
Oct 27, 2020
jsquyres
reviewed
Oct 27, 2020
jsquyres
force-pushed
the
date
branch
2 times, most recently
from
6e683fe
to
ee6c9bf
Compare
If defined, use SOURCE_DATE_EPOCH environment variable; make the build Reproducible by forcing timestamps. See https://reproducible-builds.org/docs/source-date-epoch/ for more information. Thanks Bernhard M. Wiedemann for bringing this to our attention. Fixes open-mpi#3759 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de> Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
approved these changes
Oct 28, 2020
This was referenced Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If defined, use SOURCE_DATE_EPOCH environment variable make the build
Reproducible by forcing timestamps. See
https://reproducible-builds.org/docs/source-date-epoch/ for more
information.
Thanks Bernhard M. Wiedemann for bringing this to our attention.
Fixes #3759
This is mostly a rebase of #3779 by @ggouaillardet with some feedback from @jsquyres applied.