Skip to content

osc/sm: fix remaining coverity issues #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2015
Merged

osc/sm: fix remaining coverity issues #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ompi/mca/osc/sm/osc_sm_active_target.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ ompi_osc_sm_start(struct ompi_group_t *group,

for (int i = 0 ; i < size ; ++i) {
int rank_byte = ranks[i] >> 6;
uint64_t old, rank_bit = 1 << (ranks[i] & 0x3f);
uint64_t old, rank_bit = ((uint64_t) 1) << (ranks[i] & 0x3f);

/* wait for rank to post */
while (!(module->posts[my_rank][rank_byte] & rank_bit)) {
Expand Down Expand Up @@ -219,7 +219,7 @@ ompi_osc_sm_post(struct ompi_group_t *group,
(ompi_osc_sm_module_t*) win->w_osc_module;
int my_rank = ompi_comm_rank (module->comm);
int my_byte = my_rank >> 6;
uint64_t my_bit = 1 << (my_rank & 0x3f);
uint64_t my_bit = ((uint64_t) 1) << (my_rank & 0x3f);
int gsize;

OPAL_THREAD_LOCK(&module->lock);
Expand Down
3 changes: 2 additions & 1 deletion ompi/mca/osc/sm/osc_sm_component.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,10 +477,11 @@ ompi_osc_sm_free(struct ompi_win_t *win)

/* cleanup */
ompi_comm_free(&module->comm);
free(module);

OBJ_DESTRUCT(&module->lock);

free(module);

return OMPI_SUCCESS;
}

Expand Down