osc/pt2pt: fix coveity issues #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed CID 1269712, 1269709, 1269706, 1269703, 1269694: Logically dead code Remove extra NULL check as OMPI_OSC_PT2PT_REQUEST_ALLOC can never set the request to NULL. Fixes CID 1269668: Unchecked return value False positive. Add (void) to indicate we do not care about the return code from opal_hash_table_get_uint32. Fixes CID 1324726: Free of address-of expression Do not free lock if it was not allocated. Fixes CID 1269658: Free of address-of expression Never will happen but because op is always a built-in op there is no reason to retain/release it anyway. Signed-off-by: Nathan Hjelm <hjelmn@me.com>
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
…_unique_datafile osc/sm: create datafile into the per proc directory in order to make …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed CID 1269712, 1269709, 1269706, 1269703, 1269694: Logically dead code
Remove extra NULL check as OMPI_OSC_PT2PT_REQUEST_ALLOC can never set the
request to NULL.
Fixes CID 1269668: Unchecked return value
False positive. Add (void) to indicate we do not care about the return code
from opal_hash_table_get_uint32.
Fixes CID 1324726: Free of address-of expression
Do not free lock if it was not allocated.
Fixes CID 1269658: Free of address-of expression
Never will happen but because op is always a built-in op there is no
reason to retain/release it anyway.
Signed-off-by: Nathan Hjelm hjelmn@me.com