Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore to not ignore logs packages #98

Merged
merged 6 commits into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@maxsmythe
Copy link
Contributor

commented Apr 25, 2019

Signed-off-by: Max Smythe smythe@google.com

maxsmythe added some commits Apr 25, 2019

Update gitignore to not ignore logs packages
Signed-off-by: Max Smythe <smythe@google.com>
Explicitly include vendor directory
Signed-off-by: Max Smythe <smythe@google.com>
No need to run dep ensure
Signed-off-by: Max Smythe <smythe@google.com>
No need to install dep
Signed-off-by: Max Smythe <smythe@google.com>
Fix error in explicit inclusion of all vendor subpackages
Signed-off-by: Max Smythe <smythe@google.com>
Remove vistigial config/default/manager_image_patch.yaml
Signed-off-by: Max Smythe <smythe@google.com>

@maxsmythe maxsmythe force-pushed the maxsmythe:fix-gitignore branch from 2339499 to d503c7a Apr 25, 2019

@maxsmythe maxsmythe requested a review from ritazh Apr 25, 2019

@maxsmythe maxsmythe referenced this pull request Apr 25, 2019

Merged

Update readme #99

@tsandall
Copy link
Member

left a comment

LGTM. One minor thought about moving artifacts into a subdirectory to avoid creating a bunch of junk in the root.

[Bb]in/
[Oo]bj/
[Ll]og/
/[Dd]ebug/

This comment has been minimized.

Copy link
@tsandall

tsandall Apr 26, 2019

Member

Is there a reason to keep all of these at the root of the project?

This comment has been minimized.

Copy link
@maxsmythe

maxsmythe Apr 26, 2019

Author Contributor

I'm not sure these get created still. They are remnants from KPC.

This comment has been minimized.

Copy link
@maxsmythe

maxsmythe Apr 26, 2019

Author Contributor

I should say, they don't get created on my Linux build, I'm unsure what other environments may do, so am being cautious.

@maxsmythe maxsmythe merged commit b9d50ae into open-policy-agent:master Apr 26, 2019

3 checks passed

DCO DCO
Details
cla/linuxfoundation maxsmythe authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxsmythe maxsmythe deleted the maxsmythe:fix-gitignore branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.