From 18aa5d9e32a32ddb70d038507774a88ed7f644fc Mon Sep 17 00:00:00 2001 From: Amit Tendolkar Date: Thu, 18 Jul 2019 04:56:03 -0500 Subject: [PATCH] HCode Error Logs - Final structure change for PGPE-OCC API Changes to clean unwanted symbols Changes to support only unrecoverable error (1) in HCode error logs Changes to remove reserved member, such that errlog_idx match the spec. Change-Id: I2b56905e5ea2f7d3b4c879be9b4563d9ccbb983b RTC: 207368 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80598 Reviewed-by: Christopher J Cain Tested-by: Jenkins Server Reviewed-by: Martha Broyles Tested-by: Hostboot CI Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA Reviewed-by: Gregory S Still Tested-by: FSP CI Jenkins Reviewed-by: Jennifer A Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80661 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Christian R Geddes Tested-by: Christian R Geddes --- .../pmlib/include/pstate_pgpe_occ_api.h | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/import/chips/p9/common/pmlib/include/pstate_pgpe_occ_api.h b/src/import/chips/p9/common/pmlib/include/pstate_pgpe_occ_api.h index e36cf2dd64e..0a51fbca36b 100644 --- a/src/import/chips/p9/common/pmlib/include/pstate_pgpe_occ_api.h +++ b/src/import/chips/p9/common/pmlib/include/pstate_pgpe_occ_api.h @@ -410,17 +410,9 @@ typedef struct // ----------------------------------------------------------------------------- // Start Error Log Table -/// Maximum number of error log entries available -#define MAX_HCODE_ELOG_ENTRIES 4 - -/// Index into the array of error log entries -enum elog_entry_index -{ - ELOG_PGPE_CRITICAL = 0, - ELOG_PGPE_INFO = 1, - ELOG_SGPE_CRITICAL = 2, - ELOG_SGPE_INFO = 3, -}; +/// Maximum number of error log entries available, 1 UE per SPGE & PGPE +#define MAX_HCODE_ELOG_ENTRIES 2 +#define HCODE_ELOG_TABLE_MAGIC_WORD 0x454C5443 // "ELTC" /// Structure of an individual error log entry typedef struct @@ -462,7 +454,7 @@ typedef struct hcode_error_table } fields; } dw0; - /// Array of error log entries (index with enum elog_entry_index) + /// Array of error log entries hcode_elog_entry_t elog[MAX_HCODE_ELOG_ENTRIES]; } hcode_error_table_t; @@ -492,9 +484,6 @@ typedef struct //PGPE WOF Values pgpe_wof_values_t pgpe_wof_values; - //Reserved - uint64_t reserved1; - /// Hcode Error Log Index hcode_error_table_t errlog_idx;