From 19f6e0687252e083fb93fbda44e945f2c3b0a69f Mon Sep 17 00:00:00 2001 From: Andre Marin Date: Wed, 25 Jan 2017 11:45:52 -0600 Subject: [PATCH] Disable DQS polarity workaround. Workaround is currently disabled, we will need to remove it completely if the lab decides this is the permanent fix. Change-Id: I6c93c3609df9bfcbc0fd48948c392bb805eaea4b Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35404 Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: BRIANA E. FOXWORTH Reviewed-by: JACOB L. HARVEY Dev-Ready: JACOB L. HARVEY Reviewed-by: Brian R. Silver Reviewed-by: Louis Stermole Reviewed-by: Jennifer A. Stofer Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35421 Reviewed-by: Hostboot Team Tested-by: Jenkins OP Build CI Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell --- .../hwp/memory/lib/mss_attribute_accessors_manual.H | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H b/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H index 7b77aa04d5f..ee92055004e 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H +++ b/src/import/chips/p9/procedures/hwp/memory/lib/mss_attribute_accessors_manual.H @@ -159,6 +159,9 @@ fapi_try_exit: template< fapi2::TargetType T > inline bool chip_ec_feature_mss_dqs_polarity(const fapi2::Target& i_target) { + // Seeing better results with Monza and LaGrange by switching this off + // TODO RTC:168029 - Remove DQS polarity EC feature if turning it off is a permanent fix. +#ifdef DO_POLARITY_WORKAROUND const auto l_chip = mss::find_target(i_target); uint8_t l_value = 0; @@ -170,6 +173,8 @@ fapi_try_exit: FAPI_ERR("failed accessing ATTR_CHIP_EC_FEATURE_MSS_DQS_POLARITY: 0x%lx (target: %s)", uint64_t(fapi2::current_err), mss::c_str(i_target)); fapi2::Assert(false); +#endif + return false; }