From 81fe4816a60871efb5053c0d406d679a18704f18 Mon Sep 17 00:00:00 2001 From: "Andre A. Marin" Date: Mon, 9 Mar 2020 23:03:52 -0500 Subject: [PATCH] Update attr_engine to handle more cases Change-Id: I9424bf4b337399c29f16c3fac9a9638c6b3eea21 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/91701 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: Hostboot CI Dev-Ready: ANDRE A MARIN Reviewed-by: STEPHEN GLANCY Reviewed-by: Mark Pizzutillo Reviewed-by: Jennifer A Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/93014 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Christian R Geddes --- .../lib/eff_config/pmic_attr_engine_traits.H | 52 +++++++++++++++++-- .../eff_config/explorer_attr_engine_traits.H | 35 +++++++++++-- .../lib/eff_config/p9n_data_init_traits.H | 5 +- .../lib/eff_config/p9a_data_init_traits.H | 9 +++- .../lib/data_engine/attr_engine_traits.H | 47 +++++++++++++++++ .../memory/lib/data_engine/data_engine.H | 5 +- .../lib/data_engine/data_engine_utils.H | 38 +++++++------- 7 files changed, 160 insertions(+), 31 deletions(-) diff --git a/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/eff_config/pmic_attr_engine_traits.H b/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/eff_config/pmic_attr_engine_traits.H index dd465bf539a..1350aaa10d1 100644 --- a/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/eff_config/pmic_attr_engine_traits.H +++ b/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/eff_config/pmic_attr_engine_traits.H @@ -74,6 +74,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_MFG_ID_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_MFG_ID; @@ -125,6 +126,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWA_VOLTAGE_SETTING_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWA_VOLTAGE_SETTING; @@ -176,6 +178,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWA_VOLTAGE_RANGE_SELECT_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWA_VOLTAGE_RANGE_SELECT; @@ -227,6 +230,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWA_VOLTAGE_OFFSET_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWA_VOLTAGE_OFFSET; @@ -286,6 +290,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWA_SEQUENCE_DELAY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWA_SEQUENCE_DELAY; @@ -337,6 +342,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWA_SEQUENCE_ORDER_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWA_SEQUENCE_ORDER; @@ -388,6 +394,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWB_VOLTAGE_SETTING_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWB_VOLTAGE_SETTING; @@ -439,6 +446,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWB_VOLTAGE_RANGE_SELECT_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWB_VOLTAGE_RANGE_SELECT; @@ -490,6 +498,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWB_VOLTAGE_OFFSET_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWB_VOLTAGE_OFFSET; @@ -549,6 +558,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWB_SEQUENCE_DELAY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWB_SEQUENCE_DELAY; @@ -600,6 +610,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWB_SEQUENCE_ORDER_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWB_SEQUENCE_ORDER; @@ -640,7 +651,6 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWC_VOLTAGE_SETTING_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWC_VOLTAGE_SETTING; @@ -703,6 +714,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWC_VOLTAGE_RANGE_SELECT_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWC_VOLTAGE_RANGE_SELECT; @@ -754,6 +766,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWC_VOLTAGE_OFFSET_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWC_VOLTAGE_OFFSET; @@ -813,6 +826,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWC_SEQUENCE_DELAY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWC_SEQUENCE_DELAY; @@ -864,6 +878,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWC_SEQUENCE_ORDER_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWC_SEQUENCE_ORDER; @@ -904,7 +919,6 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWD_VOLTAGE_SETTING_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWD_VOLTAGE_SETTING; @@ -967,6 +982,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWD_VOLTAGE_RANGE_SELECT_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWD_VOLTAGE_RANGE_SELECT; @@ -1018,6 +1034,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWD_VOLTAGE_OFFSET_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWD_VOLTAGE_OFFSET; @@ -1077,6 +1094,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWD_SEQUENCE_DELAY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWD_SEQUENCE_DELAY; @@ -1128,6 +1146,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SWD_SEQUENCE_ORDER_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SWD_SEQUENCE_ORDER; @@ -1179,6 +1198,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_PHASE_COMB_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_PHASE_COMB; @@ -1230,6 +1250,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_REDUNDANCY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_REDUNDANCY; @@ -1286,6 +1307,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_MFG_ID_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_MFG_ID; @@ -1337,6 +1359,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWA_VOLTAGE_SETTING_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWA_VOLTAGE_SETTING; @@ -1388,6 +1411,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWA_VOLTAGE_RANGE_SELECT_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWA_VOLTAGE_RANGE_SELECT; @@ -1439,6 +1463,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWA_VOLTAGE_OFFSET_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWA_VOLTAGE_OFFSET; @@ -1498,6 +1523,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWA_SEQUENCE_DELAY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWA_SEQUENCE_DELAY; @@ -1549,6 +1575,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWA_SEQUENCE_ORDER_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWA_SEQUENCE_ORDER; @@ -1600,6 +1627,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWB_VOLTAGE_SETTING_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWB_VOLTAGE_SETTING; @@ -1651,6 +1679,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWB_VOLTAGE_RANGE_SELECT_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWB_VOLTAGE_RANGE_SELECT; @@ -1702,6 +1731,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWB_VOLTAGE_OFFSET_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWB_VOLTAGE_OFFSET; @@ -1761,6 +1791,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWB_SEQUENCE_DELAY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWB_SEQUENCE_DELAY; @@ -1812,6 +1843,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWB_SEQUENCE_ORDER_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWB_SEQUENCE_ORDER; @@ -1863,6 +1895,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWC_VOLTAGE_SETTING_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWC_VOLTAGE_SETTING; @@ -1914,6 +1947,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWC_VOLTAGE_RANGE_SELECT_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWC_VOLTAGE_RANGE_SELECT; @@ -1965,6 +1999,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWC_VOLTAGE_OFFSET_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWC_VOLTAGE_OFFSET; @@ -2024,6 +2059,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWC_SEQUENCE_DELAY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWC_SEQUENCE_DELAY; @@ -2075,6 +2111,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWC_SEQUENCE_ORDER_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWC_SEQUENCE_ORDER; @@ -2126,6 +2163,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWD_VOLTAGE_SETTING_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWD_VOLTAGE_SETTING; @@ -2177,6 +2215,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWD_VOLTAGE_RANGE_SELECT_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWD_VOLTAGE_RANGE_SELECT; @@ -2228,6 +2267,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWD_VOLTAGE_OFFSET_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWD_VOLTAGE_OFFSET; @@ -2287,6 +2327,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWD_SEQUENCE_DELAY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWD_SEQUENCE_DELAY; @@ -2338,6 +2379,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SWD_SEQUENCE_ORDER_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SWD_SEQUENCE_ORDER; @@ -2389,6 +2431,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_PHASE_COMB_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_PHASE_COMB; @@ -2440,6 +2483,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_REDUNDANCY_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_REDUNDANCY; @@ -2491,6 +2535,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC0_SEQUENCE_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC0_SEQUENCE; @@ -2542,6 +2587,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PMIC1_SEQUENCE_TargetType; static constexpr pmic::ffdc_codes FFDC_CODE = pmic::SET_PMIC1_SEQUENCE; @@ -2582,6 +2628,6 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EXP_DRAM_ADDRESS_MIRRORING_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_EXP_DRAM_ADDRESS_MIRRORING; @@ -145,6 +145,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_BYTE_ENABLES_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_BYTE_ENABLES; @@ -196,6 +197,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_NIBBLE_ENABLES_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_NIBBLE_ENABLES; @@ -247,6 +249,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EXP_SPD_TAA_MIN_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_TAA_MIN; @@ -283,7 +286,7 @@ struct attrEngineTraits(i_spd_data, + return mss::calc_spd_time_in_ps(i_spd_data, o_setting); } }; @@ -294,11 +297,12 @@ struct attrEngineTraits +template struct attrEngineTraits { using attr_type = fapi2::ATTR_MEM_EFF_FOUR_RANK_MODE_Type; using attr_integral_type = std::remove_all_extents::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_FOUR_RANK_MODE_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_FOUR_RANK_MODE; @@ -357,6 +361,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DDP_COMPATIBILITY_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_DDP_COMPATIBILITY; @@ -415,6 +420,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_TSV_8H_SUPPORT_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_TSV_8H_SUPPORT; @@ -466,6 +472,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PSTATES_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_PSTATES; @@ -517,6 +524,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_MRAM_SUPPORT_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_MRAM_SUPPORT; @@ -575,6 +583,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EXP_SPD_CL_SUPPORTED_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_SPD_CL_SUPPORTED; @@ -684,6 +693,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_MODULE_THERMAL_SENSORS_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_MODULE_THERMAL_SENSORS; @@ -735,6 +745,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_0_AVAIL_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_0_AVAIL; @@ -787,6 +798,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_0_TYPE_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_0_TYPE; @@ -838,6 +850,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_0_USAGE_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_0_USAGE; @@ -889,6 +902,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_0_I2C_ADDR_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_0_I2C_ADDR; @@ -940,6 +954,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_1_AVAIL_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_1_AVAIL; @@ -992,6 +1007,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_1_TYPE_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_1_TYPE; @@ -1043,6 +1059,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_1_USAGE_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_1_USAGE; @@ -1094,6 +1111,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_1_I2C_ADDR_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_1_I2C_ADDR; @@ -1145,6 +1163,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_DIFF_AVAIL_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_DIFF_AVAIL; @@ -1197,6 +1216,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_DIFF_TYPE_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_DIFF_TYPE; @@ -1248,6 +1268,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_DIFF_USAGE_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_DIFF_USAGE; @@ -1299,6 +1320,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_THERM_SENSOR_DIFF_I2C_ADDR_TargetType; static constexpr exp::ffdc_codes FFDC_CODE = exp::SET_THERM_SENSOR_DIFF_I2C_ADDR; @@ -1349,11 +1371,12 @@ struct attrEngineTraits +template struct attrEngineTraits { using attr_type = fapi2::ATTR_MEM_DIMM_TYPE_METADATA_Type; using attr_integral_type = std::remove_all_extents::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_DIMM_TYPE_METADATA_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DIMM_TYPE_METADATA; @@ -1439,6 +1462,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_DRAM_GEN_METADATA_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_GEN_METADATA; @@ -1490,6 +1514,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_DIMM_POS_METADATA_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DIMM_POS_METADATA; @@ -1531,6 +1556,6 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_DIMM_TYPE_METADATA_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DIMM_TYPE_METADATA; @@ -377,6 +378,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_DRAM_GEN_METADATA_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_GEN_METADATA; @@ -427,6 +429,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_DIMM_POS_METADATA_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DIMM_POS_METADATA; diff --git a/src/import/chips/p9a/procedures/hwp/memory/lib/eff_config/p9a_data_init_traits.H b/src/import/chips/p9a/procedures/hwp/memory/lib/eff_config/p9a_data_init_traits.H index 599da4e524d..ee1ed578408 100644 --- a/src/import/chips/p9a/procedures/hwp/memory/lib/eff_config/p9a_data_init_traits.H +++ b/src/import/chips/p9a/procedures/hwp/memory/lib/eff_config/p9a_data_init_traits.H @@ -55,6 +55,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DIMM_TYPE_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DIMM_TYPE; @@ -128,6 +129,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_GEN_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_GEN; @@ -199,6 +201,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_HOST_TO_DDR_SPEED_RATIO_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_HOST_TO_DDR_SPEED_RATIO; @@ -277,6 +280,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_HYBRID_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_HYBRID; @@ -349,6 +353,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_HYBRID_MEMORY_TYPE_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_HYBRID_MEDIA; @@ -421,6 +426,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_NUM_MASTER_RANKS_PER_DIMM_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_MRANKS; @@ -494,6 +500,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static const fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DIMM_RANKS_CONFIGED_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DIMM_RANKS_CNFG; @@ -550,6 +557,6 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PRIM_STACK_TYPE_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_PRIM_STACK_TYPE; @@ -253,6 +254,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PRIM_DIE_COUNT_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_PRIM_DIE_COUNT; @@ -333,6 +335,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_DENSITY_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_DENSITY; @@ -406,6 +409,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_PRIM_BUS_WIDTH_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_PRIM_BUS_WIDTH; @@ -483,6 +487,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_WIDTH_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_WIDTH; @@ -561,6 +566,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_COLUMN_BITS_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_COL_ADDR_BITS; @@ -626,6 +632,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_ROW_BITS_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_ROW_ADDR_BITS; @@ -708,6 +715,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_RCV_IMP_DQ_DQS_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_RCV_IMP_DQ_DQS; @@ -780,6 +788,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_DRV_IMP_DQ_DQS_PULL_UP_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_DRV_IMP_DQ_DQS_PULL_UP; @@ -865,6 +874,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_DRV_IMP_DQ_DQS_PULL_DOWN_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_DRV_IMP_DQ_DQS_PULL_DOWN; @@ -951,6 +961,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_DRV_SLEW_RATE_DQ_DQS_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_DRV_SLEW_RATE_DQ_DQS; @@ -1002,6 +1013,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_DRV_IMP_CMD_ADDR_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_DRV_IMP_CMD_ADDR; @@ -1075,6 +1087,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_DRV_SLEW_RATE_CMD_ADDR_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_DRV_SLEW_RATE_CMD_ADDR; @@ -1126,6 +1139,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_DRV_IMP_CLK_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_DRV_IMP_CLK; @@ -1199,6 +1213,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_DRV_SLEW_RATE_CLK_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_DRV_SLEW_RATE_CLK; @@ -1250,6 +1265,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_RCV_IMP_ALERT_N_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_RCV_IMP_ALERT_N; @@ -1323,6 +1339,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_DRAM_RTT_NOM_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_DRAM_RTT_NOM; @@ -1423,6 +1440,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_DRAM_RTT_WR_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_DRAM_RTT_WR; @@ -1520,6 +1538,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_DRAM_RTT_PARK_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_DRAM_RTT_PARK; @@ -1622,6 +1641,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_DRAM_PREAMBLE_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_DRAM_PREAMBLE; @@ -1674,6 +1694,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_MC_DRV_EQ_DQ_DQS_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_MC_DRV_EQ_DQ_DQS; @@ -1725,6 +1746,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_DRAM_DRV_IMP_DQ_DQS_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_DRAM_DRV_IMP_DQ_DQS; @@ -1793,6 +1815,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_ODT_WR_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_ODT_WR; @@ -1884,6 +1907,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_ODT_RD_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_ODT_RD; @@ -1975,6 +1999,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_SI_GEARDOWN_MODE_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SI_GEARDOWN_MODE; @@ -2030,6 +2055,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_LOGICAL_RANKS_PER_DIMM_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_LOGICAL_RANKS; @@ -2100,6 +2126,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DIMM_SIZE_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DIMM_SIZE; @@ -2170,6 +2197,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_3DS_HEIGHT_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_3DS_HEIGHT; @@ -2243,6 +2271,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_DRAM_CWL_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_CWL; @@ -2340,6 +2369,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_MFG_ID_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_MFG_ID; @@ -2397,6 +2427,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TREFI_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TREFI; @@ -2534,6 +2565,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TCCD_L_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TCCD_L; @@ -2586,6 +2618,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TWTR_L_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TWTR_L; @@ -2638,6 +2671,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TWTR_S_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TWTR_S; @@ -2690,6 +2724,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TFAW_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TFAW; @@ -2742,6 +2777,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TRCD_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TRCD; @@ -2794,6 +2830,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TRP_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TRP; @@ -2846,6 +2883,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TRAS_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TRAS; @@ -2898,6 +2936,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TWR_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TWR; @@ -2950,6 +2989,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TRTP_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TRTP; @@ -3027,6 +3067,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TRRD_S_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TRRD_S; @@ -3097,6 +3138,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TRRD_L_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TRRD_L; @@ -3168,6 +3210,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TRFC_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TRFC; @@ -3296,6 +3339,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_TRFC_DLR_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_TRFC_DLR; @@ -3376,6 +3420,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_RCD_MFG_ID_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_RCD_MFG_ID; @@ -3426,6 +3471,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_DRAM_MODULE_HEIGHT_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_DRAM_MODULE_HEIGHT; @@ -3476,6 +3522,7 @@ struct attrEngineTraits::type; + using attr_type_to_set = attr_integral_type; static constexpr fapi2::TargetType TARGET_TYPE = fapi2::ATTR_MEM_EFF_SPD_REVISION_TargetType; static constexpr generic_ffdc_codes FFDC_CODE = SET_SPD_REVISION; diff --git a/src/import/generic/memory/lib/data_engine/data_engine.H b/src/import/generic/memory/lib/data_engine/data_engine.H index 6e206292b80..1ff79d7927a 100644 --- a/src/import/generic/memory/lib/data_engine/data_engine.H +++ b/src/import/generic/memory/lib/data_engine/data_engine.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2018,2019 */ +/* Contributors Listed Below - COPYRIGHT 2018,2020 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -65,7 +65,7 @@ struct attr_engine template < typename IT > static fapi2::ReturnCode single_set(const IT& i_input) { - typename TT::attr_integral_type l_value = 0; + typename TT::attr_type_to_set l_value = {}; FAPI_TRY( TT::get_value_to_set(i_input, l_value), "Failed get_value_to_set() for proc_type: %d and enum val: %d", P, F); @@ -86,6 +86,7 @@ struct attr_engine template < typename IT > static fapi2::ReturnCode set(const IT& i_input) { + FAPI_DBG("Processing field %u", F); FAPI_TRY( (attr_engine(F) == 0u>::single_set(i_input)), "Failed attr_engine::single_set() for proc_type: %d and enum val: %d", P, F); diff --git a/src/import/generic/memory/lib/data_engine/data_engine_utils.H b/src/import/generic/memory/lib/data_engine/data_engine_utils.H index 71c02f3cc81..20ee688f4b4 100644 --- a/src/import/generic/memory/lib/data_engine/data_engine_utils.H +++ b/src/import/generic/memory/lib/data_engine/data_engine_utils.H @@ -331,14 +331,14 @@ fapi_try_exit: /// @param[out] o_data output to set /// @return FAPI2_RC_SUCCESS iff okay /// -template < fapi2::TargetType T, - typename IT, - typename FFDC, - typename OT > -inline fapi2::ReturnCode update_data( const fapi2::Target& i_target, - const IT i_setting, - const FFDC i_ffdc_code, - OT& o_data ) +template +inline fapi2::ReturnCode update_data(const fapi2::Target& i_target, + const IT& i_setting, + const FFDC i_ffdc_code, + OT& o_data) { FAPI_DBG("Updating data with %d for %s", i_setting, spd::c_str(i_target)); o_data = i_setting; @@ -356,14 +356,14 @@ inline fapi2::ReturnCode update_data( const fapi2::Target& i_target, /// @param[out] o_data output to set /// @return FAPI2_RC_SUCCESS iff okay /// -template < typename DT, - typename IT, - typename FFDC, - typename OT > -inline fapi2::ReturnCode update_data( const DT& i_data, - const IT i_setting, - const FFDC i_ffdc_code, - OT& o_data ) +template +inline fapi2::ReturnCode update_data(const DT& i_data, + const IT& i_setting, + const FFDC i_ffdc_code, + OT& o_data) { o_data = i_setting; return fapi2::FAPI2_RC_SUCCESS; @@ -413,7 +413,7 @@ template< typename TT, typename DT, typename IT > inline fapi2::ReturnCode set_field(const DT& i_data, - const IT i_setting) + const IT& i_setting) { // Grab the target associated w/the data (e.g. SPD or EFD) const auto l_attr_target = get::target(i_data); @@ -525,7 +525,7 @@ fapi_try_exit: return fapi2::current_err; } -}// gen -}//mss +} // namespace gen +} // namespace mss #endif