diff --git a/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_common_utils.C b/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_common_utils.C index 5406218d65a..3c253fdbd03 100644 --- a/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_common_utils.C +++ b/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_common_utils.C @@ -334,14 +334,15 @@ fapi2::ReturnCode check_pmic( bool l_status_error = false; // if we exit from this try, there were i2c errors - FAPI_TRY(mss::pmic::status::check_fields(i_pmic_target, mss::pmic::status::IDT_SPECIFIC_STATUS_FIELDS, l_status_error)); + FAPI_TRY(mss::pmic::status::check_fields(i_pmic_target, "PMIC_WARNING_BIT", + mss::pmic::status::IDT_SPECIFIC_STATUS_FIELDS, l_status_error)); } { bool l_status_error = false; // if we exit from this try, there were i2c errors - FAPI_TRY(mss::pmic::status::check_fields(i_pmic_target, mss::pmic::status::STATUS_FIELDS, l_status_error)); + FAPI_TRY(mss::pmic::status::check_fields(i_pmic_target, "ERROR", mss::pmic::status::STATUS_FIELDS, l_status_error)); o_error = l_status_error; } @@ -380,12 +381,14 @@ fapi_try_exit: /// @brief Check an individual set of PMIC status codes /// /// @param[in] i_pmic_target PMIC target +/// @param[in] i_error_type error type for the PMIC in question /// @param[in] i_statuses STATUS object to check /// @param[out] o_error At least one error bit was found to be set /// @return fapi2::ReturnCode FAPI2_RC_SUCCESS iff success, else error in case of an I2C read error /// fapi2::ReturnCode check_fields( const fapi2::Target& i_pmic_target, + const char* i_error_type, const std::vector>>& i_statuses, bool& o_error) { @@ -401,8 +404,9 @@ fapi2::ReturnCode check_fields( if (l_reg_contents.getBit(l_status.l_reg_field)) { // Print it out - FAPI_ERR("%s :: REG 0x%02x bit %u was set on %s", + FAPI_ERR("%s %s :: REG 0x%02x bit %u was set on %s", l_status.l_error_description, + i_error_type, l_reg_bit_pair.first, l_status.l_reg_field, mss::c_str(i_pmic_target)); diff --git a/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_common_utils.H b/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_common_utils.H index 1207abb2f3e..12202674d24 100644 --- a/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_common_utils.H +++ b/src/import/chips/ocmb/common/procedures/hwp/pmic/lib/utils/pmic_common_utils.H @@ -339,15 +339,17 @@ fapi2::ReturnCode check_pmic(const fapi2::Target& i_pmi fapi2::ReturnCode clear(const fapi2::Target& i_pmic_target); /// -/// @brief Check the IDT specific status codes +/// @brief Check an individual set of PMIC status codes /// /// @param[in] i_pmic_target PMIC target +/// @param[in] i_error_type error type for the PMIC in question /// @param[in] i_statuses STATUS object to check /// @param[out] o_error At least one error bit was found to be set /// @return fapi2::ReturnCode FAPI2_RC_SUCCESS iff success, else error in case of an I2C read error /// fapi2::ReturnCode check_fields( const fapi2::Target& i_pmic_target, + const char* i_error_type, const std::vector>>& i_statuses, bool& o_error);