From 1c3f583bb767b1af43478c682b665b224b69b38e Mon Sep 17 00:00:00 2001 From: Michael Neuling Date: Thu, 21 Sep 2017 17:23:18 +1000 Subject: [PATCH] phb4: Update link training documentation We added degraded link retries in: 3f936bae97 phb4: Retrain link if degraded but forgot to update the documentation. Signed-off-by: Michael Neuling Signed-off-by: Stewart Smith --- hw/phb4.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/phb4.c b/hw/phb4.c index 5e5f50fe3aed..e929b1504e31 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -82,6 +82,14 @@ * o Once we leave here, much harder to recover from errors * * Step 9: + * - Check for optimised link for directly attached devices: + * o Wait for CRS (so we can read device config space) + * o Check chip and device are in whitelist. if not, Goto Step 10 + * o If trained link speed is degraded, retry -> Goto Step 2 + * o If trained link width is degraded, retry -> Goto Step 2 + * o If still degraded after 3 retries. Give up, Goto Step 10. + * + * Step 10: * - PHB good, start probing config space. * o core/pci.c: pci_reset_phb() -> pci_scan_phb() */