From d6fc2fb3afe7ef56415225de2114bd7ccd285d31 Mon Sep 17 00:00:00 2001 From: Oliver O'Halloran Date: Wed, 13 Nov 2019 22:43:51 +1100 Subject: [PATCH] makefiles: Make attribute suggestions non-errors Different versions of GCC don't have different ideas about when the suggestion should be made. That, combined with -Werror being enabled results in spurious compilation failures for dumb reasons. They're also really annoying when tinkering. They do however make good suggestions on occasion so leave them enabled with -Wno-error enabled so they don't cause compile failures. Signed-off-by: Oliver O'Halloran --- Makefile.main | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile.main b/Makefile.main index 2d60bbbf5e41..4d7ebcec98d7 100644 --- a/Makefile.main +++ b/Makefile.main @@ -42,7 +42,9 @@ HOSTCFLAGS += $(call try-cflag,$(HOSTCC),-std=gnu11) HOSTCFLAGS += $(call try-cflag,$(HOSTCC),-m64) HOSTCFLAGS += $(call try-cflag,$(HOSTCC),-Wjump-misses-init) \ $(call try-cflag,$(HOSTCC),-Wsuggest-attribute=const) \ - $(call try-cflag,$(HOSTCC),-Wsuggest-attribute=noreturn) + $(call try-cflag,$(HOSTCC),-Wsuggest-attribute=noreturn) \ + $(call try-cflag,$(HOSTCC),-Wno-error=suggest-attribute=const) \ + $(call try-cflag,$(HOSTCC),-Wno-error=suggest-attribute=noreturn) HOSTCFLAGS += -DDEBUG -DCCAN_LIST_DEBUG # We want small stack usage for skiboot @@ -126,6 +128,8 @@ endif CFLAGS += $(call try-cflag,$(CC),-Wjump-misses-init) \ $(call try-cflag,$(CC),-Wsuggest-attribute=const) \ $(call try-cflag,$(CC),-Wsuggest-attribute=noreturn) \ + $(call try-cflag,$(CC),-Wno-error=suggest-attribute=const) \ + $(call try-cflag,$(CC),-Wno-error=suggest-attribute=noreturn) \ $(call try-cflag,$(CC),-Wstack-usage=1024) \ $(call try-cflag,$(CC),-Wno-error=address-of-packed-member)