Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and passes for aarch64 const time checks #1214

Merged
merged 1 commit into from May 25, 2022

Conversation

tedeaton
Copy link
Contributor

This adds passes & issues to the constant time check files for algorithms built on aarch64 platforms.

The only issue is a memcheck overlap problem observed in SPHINCS, which has already been noted (see Issue #1038 ). Everything else is expected behaviour.

Resolves #1119 .

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the the list of algorithms available -- either adding, removing, or renaming? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)

@tedeaton tedeaton marked this pull request as ready for review May 20, 2022 16:35
@dstebila dstebila merged commit feea2f3 into main May 25, 2022
@dstebila dstebila deleted the aarch64-const-time-checks branch May 25, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant time checks for aarch64
2 participants