Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for galactic #25

Merged
merged 1 commit into from Jun 9, 2021
Merged

Changes for galactic #25

merged 1 commit into from Jun 9, 2021

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Jun 9, 2021

Tried building rmf with galactic and ran into build errors with packages in this repo. I think some of these changes were missed in #23

Fix open-rmf/rmf#60

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund requested a review from gbiggs June 9, 2021 11:55
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #25 (a52229c) into main (fb0f90f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main     #25     +/-   ##
=======================================
  Coverage   0.00%   0.00%             
=======================================
  Files        134      46     -88     
  Lines      11208    3752   -7456     
=======================================
+ Misses     11208    3752   -7456     
Flag Coverage Δ
tests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ation/rmf_robot_sim_gazebo_plugins/src/slotcar.cpp
...ation/rmf_robot_sim_gazebo_plugins/src/slotcar.cpp
...tion/rmf_robot_sim_common/src/dispenser_common.cpp
..._robot_sim_gazebo_plugins/src/TeleportIngestor.cpp
...lation/rmf_building_sim_common/src/lift_common.cpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
.../rmf_simulation/rmf_robot_sim_common/src/utils.cpp
...uilding_sim_gazebo_plugins/src/crowd_simulator.hpp
...ation/rmf_robot_sim_common/src/readonly_common.cpp
...building_sim_common/src/crowd_simulator_common.cpp
... and 166 more

@gbiggs gbiggs merged commit a66644a into main Jun 9, 2021
@gbiggs gbiggs deleted the galactic branch June 9, 2021 23:08
arjo129 pushed a commit that referenced this pull request Jun 10, 2021
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129 added a commit that referenced this pull request Jun 10, 2021
* Add support for ASAN address sanitizer

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Make it weekly instead.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Update to container tooling version

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Changes and corrections to support ROS 2 Galactic (#23)

Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>

Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Update asan.yaml

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

* Changes for galactic (#25)

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>

Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org>
Co-authored-by: Yadu <yadunund@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Galactic
2 participants