change parameter tag from holonomic to steering

[ddengster]

Signed-off-by: ddengster ed.fan@osrfoundation.org

Bug fix

Fixed bug

changed <holonomic> tags to <steering> tag for greater clarity. Likewise for code references.

[codecov]

Codecov Report

Merging #46 (9e0001d) into main (3d211fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main     #46      +/-   ##
========================================
  Coverage   0.00%   0.00%              
========================================
  Files        336     138     -198     
  Lines      31946   12873   -19073     
========================================
+ Misses     31946   12873   -19073     

Flag	Coverage Δ
tests	0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
..._robot_sim_gazebo_plugins/src/TeleportIngestor.cpp
...uilding_sim_gazebo_plugins/src/toggle_charging.cpp
...on/include/rmf_robot_sim_common/slotcar_common.hpp
...tion/rmf_robot_sim_common/src/dispenser_common.cpp
...building_sim_common/src/crowd_simulator_common.cpp
...m_ignition_plugins/src/LightTuning/LightTuning.cpp
..._sim_common/include/rmf_robot_sim_common/utils.hpp
...bot_sim_ignition_plugins/src/TeleportDispenser.cpp
...ation/rmf_building_sim_gazebo_plugins/src/door.cpp
...ing_sim_gazebo_plugins/src/thumbnail_generator.cpp
... and 452 more

[Yadunund]

The changes here are okay with me. We can merge after @luca-della-vedova takes a look.

[luca-della-vedova]

I think we can use a hash map that maps a string to an enum (maybe called VehicleDriveType or something along those lines), so it would be a bit clearer, i.e. go from SlotcarCommon::DIFF_DRIVE to VehicleDriveType::DIFF_DRIVE.
Something similar to what we do for checking the physics engine plugin here

[ddengster]

switch to enum 2e157ce, no need for the unordered map atm since it's only used in a single area

[luca-della-vedova]

I did a quick grep in the rmf codebase and noticed that we don't do uppercase enum class, the convention seems to be on UpperCamelCase, also having to write SlotcarCommon::STEERING_TYPE::ACKERMANN is quite verbose, you can bring the definition of the enum class outside of the SlotcarCommon class to get rid of the first scope. Since it would be in the rmf_robot_sim_common namespace there is no risk of polluting other namespaces.

[ddengster]

fixed 9e0001d

[luca-della-vedova]

Thanks for the fixes!