Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate return values #6

Closed
shanejonas opened this issue Apr 22, 2019 · 2 comments · Fixed by #7
Closed

Validate return values #6

shanejonas opened this issue Apr 22, 2019 · 2 comments · Fixed by #7
Assignees
@shanejonas
Labels
bug Something isn't working released
Projects
OpenRPC

Comments

@shanejonas
Copy link
Member

Describe the issue
Currently it only creates parameters from the openrpc.json and is a Success when it returns results with no errors.

Describe the solution
It should only have success it the result values match the openrpc.json result schema
@shanejonas shanejonas self-assigned this Apr 22, 2019
@shanejonas shanejonas added this to To do in OpenRPC via automation Apr 22, 2019
@shanejonas shanejonas added the bug Something isn't working label Apr 22, 2019
@shanejonas
Copy link
Member Author

fixed in #7

OpenRPC automation moved this from To do to Done Apr 22, 2019
@shanejonas shanejonas mentioned this issue Apr 22, 2019
Merged
@shanejonas
Copy link
Member Author

🎉 This issue has been resolved in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanejonas shanejonas

Labels
bug Something isn't working released
Projects
OpenRPC
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add result validation open-rpc/test-coverage
1 participant
@shanejonas