Conversation
The previous configuration only excluded venv directories via the wheel target's exclude list. Since hatchling's sdist target defaults to including everything not in .gitignore, a `.venv-release/` created in the project root during the release procedure leaked into the tarball. Mirror pythainer's fix: - add a top-level [tool.hatch.build] exclude for venv/env/cache/git dirs that both targets inherit; - add an explicit [tool.hatch.build.targets.sdist] exclude block (the actual fix); - harmonize the wheel exclude patterns to use root-anchored globs. Signed-off-by: Antonio Paolillo <apaolill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous configuration only excluded venv directories via the wheel target's exclude list. Since hatchling's sdist target defaults to including everything not in .gitignore, a
.venv-release/created in the project root during the release procedure leaked into the tarball.Mirror pythainer's fix: