Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix re-rendering of Highlights "Repositories" table with duplicates #1811

Merged
merged 3 commits into from Oct 9, 2023

Conversation

5hraddha
Copy link
Contributor

@5hraddha 5hraddha commented Oct 5, 2023

Description

This PR:

  1. fixes the React paint issue by keeping the key props value unique and thus, also handles the vertical expansion of "Repositories" table that was leading to spillage.
  2. filters the duplicate repos to make sure only unique repos are rendered in Highlights "Repositories" table at /feed.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #1779

Mobile & Desktop Screenshots/Recordings

Before the change

opensauced-before-react-rerendering-fix.mp4

After the change

opensauced-after-react-rerendering-fix.mp4

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Oct 5, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 92a74cd
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/651ee3d42874db00088d6327
😎 Deploy Preview https://deploy-preview-1811--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 5, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 92a74cd
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/651ee3d42b5b3e00087f0a89
😎 Deploy Preview https://deploy-preview-1811--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts requested a review from a team October 5, 2023 15:23
Copy link
Member

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @5hraddha πŸ‘πŸ‘

@OgDev-01 OgDev-01 requested a review from a team October 6, 2023 09:37
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ•

@OgDev-01 OgDev-01 merged commit f729457 into open-sauced:beta Oct 9, 2023
10 checks passed
open-sauced bot pushed a commit that referenced this pull request Oct 9, 2023
## [1.68.0-beta.11](v1.68.0-beta.10...v1.68.0-beta.11) (2023-10-09)

### πŸ• Features

* implemented list activity page with most active contributors graph ([#1796](#1796)) ([0c9b1e2](0c9b1e2))

### πŸ› Bug Fixes

* Fix re-rendering of Highlights "Repositories" table with duplicates ([#1811](#1811)) ([f729457](f729457))
open-sauced bot pushed a commit that referenced this pull request Oct 10, 2023
## [1.68.0](v1.67.0...v1.68.0) (2023-10-10)

### 🎨 Styles

* add w-full ([9b156d1](9b156d1))
* remove unused style prop ([1fe65c0](1fe65c0))

### πŸ• Features

* add form to user settings to apply coupon code ([#1771](#1771)) ([504d7e2](504d7e2))
* add new lists creation page ([#1798](#1798)) ([7ebc99b](7ebc99b))
* add prototype contributor activity charts ([#1594](#1594)) ([379db6d](379db6d))
* add timezone filters for list contributors ([#1747](#1747)) ([674a588](674a588))
* add Treemap chart prototype ([#1569](#1569)) ([f057de8](f057de8))
* implemented list activity page with most active contributors graph ([#1796](#1796)) ([0c9b1e2](0c9b1e2))
* move range filter to list pages header ([#1817](#1817)) ([0b82760](0b82760))

### πŸ› Bug Fixes

* add style prop to SearchProps ([16fbc82](16fbc82))
* adjust style to fit urls ([55a6bbc](55a6bbc))
* disable tier session check ([#1840](#1840)) ([173227b](173227b))
* Fix re-rendering of Highlights "Repositories" table with duplicates ([#1811](#1811)) ([f729457](f729457))
* hide weird top nav for edit insight page ([#1809](#1809)) ([f3da2a1](f3da2a1))
* Improve the input's width to accommodate full URL ([#1789](#1789)) ([e37df4f](e37df4f))
* now range filter works on list contributors page ([d711207](d711207))
* now range filter works on list contributors page grid view ([#1819](#1819)) ([989ebba](989ebba))
* pass list name and public flag to contributor search ([#1832](#1832)) ([d54ddab](d54ddab))
* removed GitHub avatar when loading user profile avatars ([9b81371](9b81371))
* removed GitHub avatar when loading user profile avatars ([#1781](#1781)) ([49ba38f](49ba38f))
* show insight link for not onboarded users ([#1830](#1830)) ([566b0d1](566b0d1))
* update GitHub API request for user following ([#1833](#1833)) ([d62f557](d62f557))

### πŸ§‘β€πŸ’» Code Refactoring

* redirect user to newly created insight page after creation ([#1808](#1808)) ([cf12456](cf12456))
* remove unused props in Search component ([783b1c9](783b1c9))
* update all collaboration copy to connection ([#1831](#1831)) ([c0bb683](c0bb683))
* use api timezone options for contributors filter ([#1827](#1827)) ([f7276e9](f7276e9))
@5hraddha 5hraddha deleted the shraddha/fix-table-rerender branch October 16, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Highlights "Repositories" table rerenders with duplicates and spills over page eventually
4 participants