New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove + icon from list contributors stacked avatar #1851
Merged
brandonroberts
merged 2 commits into
open-sauced:beta
from
5hraddha:shraddha/remove-plus-icon
Oct 10, 2023
Merged
refactor: Remove + icon from list contributors stacked avatar #1851
brandonroberts
merged 2 commits into
open-sauced:beta
from
5hraddha:shraddha/remove-plus-icon
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jpmcb
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
brandonroberts
approved these changes
Oct 10, 2023
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
## [1.69.0-beta.3](v1.69.0-beta.2...v1.69.0-beta.3) (2023-10-10) ### π§βπ» Code Refactoring * Remove + icon from list contributors stacked avatar ([#1851](#1851)) ([264f0dd](264f0dd))
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
## [1.69.0](v1.68.0...v1.69.0) (2023-10-11) ### π§βπ» Code Refactoring * Remove + icon from list contributors stacked avatar ([#1851](#1851)) ([264f0dd](264f0dd)) ### π Features * add `Add to list` dropdown to user profile ([#1843](#1843)) ([4d81040](4d81040)) * add contributor search to list contributors ([#1862](#1862)) ([8e99a1d](8e99a1d)) * add lists link to global top nav ([#1861](#1861)) ([9dd61be](9dd61be)) * add repos/contributors treemap to list activity page ([#1853](#1853)) ([70a67f0](70a67f0)) * display featured insight pages to new contributors ([#1859](#1859)) ([5344c59](5344c59)) * upgrade posthog version to support posthog survey feedback ([#1857](#1857)) ([ca44b27](ca44b27)) ### π Bug Fixes * fixed API querystring param for repo_id for treemap API call ([0b914ba](0b914ba)) * made dynamic treemap import ssr false ([9a94bf0](9a94bf0)) * Repos with long names get cut off ([#1769](#1769)) ([cabf292](cabf292)) * show link to hub list page in nav ([#1858](#1858)) ([099b1aa](099b1aa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
+icon from list contributors stacked avatar on/hub/listsroute as currently it's not doing anything.What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1847
Mobile & Desktop Screenshots/Recordings
Before the change:

After the change:

Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?