Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove + icon from list contributors stacked avatar #1851

Merged
merged 2 commits into from Oct 10, 2023

Conversation

5hraddha
Copy link
Contributor

Description

This PR removes + icon from list contributors stacked avatar on /hub/lists route as currently it's not doing anything.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #1847

Mobile & Desktop Screenshots/Recordings

Before the change:
image

After the change:
image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Oct 10, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 618c632
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6525a1d983ca7c0008543642
😎 Deploy Preview https://deploy-preview-1851--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 10, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 618c632
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6525a1d932d57b0009cd8cea
😎 Deploy Preview https://deploy-preview-1851--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brandonroberts brandonroberts merged commit 264f0dd into open-sauced:beta Oct 10, 2023
10 checks passed
open-sauced bot pushed a commit that referenced this pull request Oct 10, 2023
## [1.69.0-beta.3](v1.69.0-beta.2...v1.69.0-beta.3) (2023-10-10)

### πŸ§‘β€πŸ’» Code Refactoring

* Remove + icon from list contributors stacked avatar ([#1851](#1851)) ([264f0dd](264f0dd))
open-sauced bot pushed a commit that referenced this pull request Oct 11, 2023
## [1.69.0](v1.68.0...v1.69.0) (2023-10-11)

### πŸ§‘β€πŸ’» Code Refactoring

* Remove + icon from list contributors stacked avatar ([#1851](#1851)) ([264f0dd](264f0dd))

### πŸ• Features

* add `Add to list` dropdown to user profile ([#1843](#1843)) ([4d81040](4d81040))
* add contributor search to list contributors ([#1862](#1862)) ([8e99a1d](8e99a1d))
* add lists link to global top nav ([#1861](#1861)) ([9dd61be](9dd61be))
* add repos/contributors treemap to list activity page ([#1853](#1853)) ([70a67f0](70a67f0))
* display featured insight pages to new contributors ([#1859](#1859)) ([5344c59](5344c59))
* upgrade posthog version to support posthog survey feedback ([#1857](#1857)) ([ca44b27](ca44b27))

### πŸ› Bug Fixes

* fixed API querystring param for repo_id for treemap API call ([0b914ba](0b914ba))
* made dynamic treemap import ssr false ([9a94bf0](9a94bf0))
* Repos with long names get cut off ([#1769](#1769)) ([cabf292](cabf292))
* show link to hub list page in nav ([#1858](#1858)) ([099b1aa](099b1aa))
@5hraddha 5hraddha deleted the shraddha/remove-plus-icon branch October 16, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove + icon from list contributors stacked avatar
4 participants