Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix horizontal padding /spacing on smaller screens for the Create New List form #1909

Merged
merged 3 commits into from Oct 19, 2023

Conversation

5hraddha
Copy link
Contributor

Description

This PR fixes the horizontal padding /spacing on smaller screens for the Create New List form at /hub/lists/new page.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #1895

Mobile & Desktop Screenshots/Recordings

Before the change

opensauced-bug-create-list.mp4

After the change

opensauced-bug-create-list-after-fix.mp4

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Oct 16, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit c0e958d
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/652daf1b8ed0c6000849082a
😎 Deploy Preview https://deploy-preview-1909--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 16, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit c0e958d
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/652daf1b503144000812cbce
😎 Deploy Preview https://deploy-preview-1909--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ•

@brandonroberts brandonroberts merged commit e92a3d9 into open-sauced:beta Oct 19, 2023
10 checks passed
open-sauced bot pushed a commit that referenced this pull request Oct 19, 2023
## [1.71.0-beta.21](v1.71.0-beta.20...v1.71.0-beta.21) (2023-10-19)

### πŸ› Bug Fixes

* Fix horizontal padding /spacing on smaller screens for the Create New List form ([#1909](#1909)) ([e92a3d9](e92a3d9))
open-sauced bot pushed a commit that referenced this pull request Oct 19, 2023
## [1.71.0](v1.70.0...v1.71.0) (2023-10-19)

### ⏩ Reverts

* clojure feature changes made directly to beta ([#1900](#1900)) ([7564245](7564245))

### πŸ• Features

* add clojure to dashboard interests ([7373865](7373865))
* add clojure to dashboard interests ([#1901](#1901)) ([e628041](e628041))
* add identifier to analytics ([#1887](#1887)) ([8169213](8169213))
* add keyboard binding for posting a highlight ([#1894](#1894)) ([346adff](346adff))
* Add OS detection hook and update search dialog ([#1760](#1760)) ([585a2aa](585a2aa))
* implemented usage of posthog.identify(identifier) ([30a4bc0](30a4bc0))
* issue support ([#1890](#1890)) ([a067789](a067789))
* show onboarding button on small screens ([#1803](#1803)) ([faf54bd](faf54bd))

### πŸ› Bug Fixes

* add check for listId to hooks ([#1869](#1869)) ([4bde212](4bde212))
* add responsiveness to profile detail ([#1892](#1892)) ([7466144](7466144))
* add target for the highlight link ([#1897](#1897)) ([d89d94b](d89d94b))
* Added isLoading condition to the title ([#1886](#1886)) ([03cd66d](03cd66d))
* adjust style for newsletter form so that it adjusts for smaller screens ([#1782](#1782)) ([9d97030](9d97030))
* attempt to clear any present service workers ([#1889](#1889)) ([e641223](e641223))
* can't update user profile bio passed 256 chars ([00a77be](00a77be))
* can't update user profile bio passed 256 chars ([#1898](#1898)) ([42c99c7](42c99c7))
* decreased delay time of tooltips ([3aef3c0](3aef3c0))
* decreased delay time of tooltips ([#1923](#1923)) ([fc50edf](fc50edf))
* Fix CSS inconsistency in Contributor Highlights for "Home" and "Following" tabs for `/feed` route ([#1783](#1783)) ([ad08c16](ad08c16))
* Fix horizontal padding /spacing on smaller screens for the Create New List form ([#1909](#1909)) ([e92a3d9](e92a3d9))
* hide secondary header in create insights page ([#1925](#1925)) ([a5245f7](a5245f7))
* list header misalignment now properly aligned ([#1941](#1941)) ([0224fa8](0224fa8))
* made active tab forecolor more prominent for hub navigation ([eeee241](eeee241))
* made active tab forecolor more prominent for hub navigation ([#1921](#1921)) ([fe997ed](fe997ed))
* match graph tooltip color with graph nodes ([#1930](#1930)) ([3f845d2](3f845d2))
* Modify Button Text ([#1942](#1942)) ([19a3484](19a3484))
* now legend labels in most active graph tooltip render properly ([#1927](#1927)) ([8a0ff79](8a0ff79))
* now treemap on list activity page appears on small screens ([c6ffb4a](c6ffb4a))
* now treemap on list activity page appears on small screens ([#1873](#1873)) ([92f9790](92f9790))
* refactored parameters for captureAnalytics to an object ([a2af672](a2af672))
* replace hash icon to arrow down for filter select ([#1825](#1825)) ([ee13255](ee13255))
* reset input state of delete list dialog box after closing the dialog and deleting the list ([#1877](#1877)) ([397570d](397570d))
* Unnecesary X-Scrollbar in tablist ([#1881](#1881)) ([9d72aeb](9d72aeb))
* update redirect paths to remove navigation errors ([#1888](#1888)) ([a2159d8](a2159d8))
@5hraddha 5hraddha deleted the shraddha/fix-padding branch November 10, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: The Create New List form is not having proper horizontal padding /spacing on smaller screens
3 participants