fix: Modify Button Text #1942
Merged
fix: Modify Button Text #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng of the action.
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## [1.71.0-beta.20](v1.71.0-beta.19...v1.71.0-beta.20) (2023-10-19) ### 🐛 Bug Fixes * Modify Button Text ([#1942](#1942)) ([19a3484](19a3484))
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## [1.71.0](v1.70.0...v1.71.0) (2023-10-19) ### ⏩ Reverts * clojure feature changes made directly to beta ([#1900](#1900)) ([7564245](7564245)) ### 🍕 Features * add clojure to dashboard interests ([7373865](7373865)) * add clojure to dashboard interests ([#1901](#1901)) ([e628041](e628041)) * add identifier to analytics ([#1887](#1887)) ([8169213](8169213)) * add keyboard binding for posting a highlight ([#1894](#1894)) ([346adff](346adff)) * Add OS detection hook and update search dialog ([#1760](#1760)) ([585a2aa](585a2aa)) * implemented usage of posthog.identify(identifier) ([30a4bc0](30a4bc0)) * issue support ([#1890](#1890)) ([a067789](a067789)) * show onboarding button on small screens ([#1803](#1803)) ([faf54bd](faf54bd)) ### 🐛 Bug Fixes * add check for listId to hooks ([#1869](#1869)) ([4bde212](4bde212)) * add responsiveness to profile detail ([#1892](#1892)) ([7466144](7466144)) * add target for the highlight link ([#1897](#1897)) ([d89d94b](d89d94b)) * Added isLoading condition to the title ([#1886](#1886)) ([03cd66d](03cd66d)) * adjust style for newsletter form so that it adjusts for smaller screens ([#1782](#1782)) ([9d97030](9d97030)) * attempt to clear any present service workers ([#1889](#1889)) ([e641223](e641223)) * can't update user profile bio passed 256 chars ([00a77be](00a77be)) * can't update user profile bio passed 256 chars ([#1898](#1898)) ([42c99c7](42c99c7)) * decreased delay time of tooltips ([3aef3c0](3aef3c0)) * decreased delay time of tooltips ([#1923](#1923)) ([fc50edf](fc50edf)) * Fix CSS inconsistency in Contributor Highlights for "Home" and "Following" tabs for `/feed` route ([#1783](#1783)) ([ad08c16](ad08c16)) * Fix horizontal padding /spacing on smaller screens for the Create New List form ([#1909](#1909)) ([e92a3d9](e92a3d9)) * hide secondary header in create insights page ([#1925](#1925)) ([a5245f7](a5245f7)) * list header misalignment now properly aligned ([#1941](#1941)) ([0224fa8](0224fa8)) * made active tab forecolor more prominent for hub navigation ([eeee241](eeee241)) * made active tab forecolor more prominent for hub navigation ([#1921](#1921)) ([fe997ed](fe997ed)) * match graph tooltip color with graph nodes ([#1930](#1930)) ([3f845d2](3f845d2)) * Modify Button Text ([#1942](#1942)) ([19a3484](19a3484)) * now legend labels in most active graph tooltip render properly ([#1927](#1927)) ([8a0ff79](8a0ff79)) * now treemap on list activity page appears on small screens ([c6ffb4a](c6ffb4a)) * now treemap on list activity page appears on small screens ([#1873](#1873)) ([92f9790](92f9790)) * refactored parameters for captureAnalytics to an object ([a2af672](a2af672)) * replace hash icon to arrow down for filter select ([#1825](#1825)) ([ee13255](ee13255)) * reset input state of delete list dialog box after closing the dialog and deleting the list ([#1877](#1877)) ([397570d](397570d)) * Unnecesary X-Scrollbar in tablist ([#1881](#1881)) ([9d72aeb](9d72aeb)) * update redirect paths to remove navigation errors ([#1888](#1888)) ([a2159d8](a2159d8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the text of the button to "Create List" from "Add to List +" so that it matches the button action. Previously,
when you click the "Add to list" button, it creates the list.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Closes #1935
Mobile & Desktop Screenshots/Recordings
Before
276251618-3fe99bf5-3174-421f-99b4-cc166e472168.mov
After
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?