refactor: Improve UX on Create New List page - /hub/lists/new
#1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for oss-insights accepted.
|
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
isabensusan
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
This is much better, thank you for the great work @5hraddha !!
open-sauced bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
## [1.73.0](v1.72.0...v1.73.0) (2023-10-26) ### 🍕 Features * implement improved UX for non-connected users profile ([#1992](#1992)) ([f11160c](f11160c)) ### 🧑💻 Code Refactoring * Improve UX on Create New List page - `/hub/lists/new` ([#1987](#1987)) ([c0fcf7a](c0fcf7a)) ### 🐛 Bug Fixes * add logic to force the user to tag at least one repository to a highlight ([#2007](#2007)) ([665fbf2](665fbf2)) * background color in text-input ([#1998](#1998)) ([1913462](1913462)) * more menu overlap issue on safari ([#1999](#1999)) ([66df010](66df010)) * now the error message in highlight form will alert assistive tech ([#2008](#2008)) ([a0d4b3b](a0d4b3b)) * set border radius for modals in small screens ([#2004](#2004)) ([738c714](738c714)) * show contributors name and company in table ([#2012](#2012)) ([79776a3](79776a3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves UX on Create New List page -
/hub/lists/newby:<InfoCard />component to make it responsive.Note: There are still many accessibility issues that needs to be taken care of. A few important issues being:
Team, please let me know how you want to handle the issues above.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1934
Mobile & Desktop Screenshots/Recordings
Before the refactor:
opensauced-create-list-ux-before-fix.mp4
After the refactor:
opensauced-create-list-ux-after-fix.mp4
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?