feat: implemented the Contributions by type of contributor graph for the list activity page #2101

nickytonline · 2023-11-10T03:34:45Z

Description

Created the Contributions by type of contributor for the list activity page. It can be filtered by date range. Note the original graph has been reworked to be an average line chart and not a raw line chart.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Closes #1601

Mobile & Desktop Screenshots/Recordings

CleanShot.2023-11-10.at.10.19.21.mp4

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-11-10T03:34:50Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`84b5eab`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/65524dd954fec500082ab011
😎 Deploy Preview	https://deploy-preview-2101--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-11-10T03:34:51Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`84b5eab`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/65524dd9710d2c000888a200
😎 Deploy Preview	https://deploy-preview-2101--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…tor graph type

nickytonline · 2023-11-10T15:31:31Z

The graphs in some cases look kind of wonky. Discussing this with @jpmcb and @isabensusan.

components/molecules/ContributionsEvolutionByTypeCard/contributions-evolution-by-type-card.tsx

nickytonline · 2023-11-10T15:50:55Z

Just investigating the page freezing. Lots of data in the pipe apparently.

You are on the server
Warning: data for page "/lists/[listId]/activity" (path "/lists/8b371419-6219-4448-9de1-f6293a25f98e/activity") is 2.31 MB which exceeds the threshold of 128 kB, this amount of data can reduce performance.
See more info here: https://nextjs.org/docs/messages/large-page-data

nickytonline · 2023-11-10T16:00:26Z

Just investigating the page freezing. Lots of data in the pipe apparently.

You are on the server
Warning: data for page "/lists/[listId]/activity" (path "/lists/8b371419-6219-4448-9de1-f6293a25f98e/activity") is 2.31 MB which exceeds the threshold of 128 kB, this amount of data can reduce performance.
See more info here: https://nextjs.org/docs/messages/large-page-data

This doesn't appear to be related to my PR. I happened to load a list that has a lot of data (server-side props data for other graphs). I'll create a separate issue for this to maybe load that component's data client-side only. Looks like it's the Treemap component.

jpmcb

Very solid!!! 👏🏼

nickytonline · 2023-11-10T17:40:07Z

Just investigating the page freezing. Lots of data in the pipe apparently.
You are on the server
Warning: data for page "/lists/[listId]/activity" (path "/lists/8b371419-6219-4448-9de1-f6293a25f98e/activity") is 2.31 MB which exceeds the threshold of 128 kB, this amount of data can reduce performance.
See more info here: https://nextjs.org/docs/messages/large-page-data
This doesn't appear to be related to my PR. I happened to load a list that has a lot of data (server-side props data for other graphs). I'll create a separate issue for this to maybe load that component's data client-side only. Looks like it's the Treemap component.

Looks like in one of my test lists I had added dependabot who happens to contribute to a few repos. 😅 I removed them from my test list and all good now.

brandonroberts

📈

…tions-evolution-by-contributor-type-graph

nickytonline · 2023-11-13T16:29:39Z

The graphs in some cases look kind of wonky. Discussing this with @jpmcb and @isabensusan.

As we discussed, we'll iterate on this graph as need be, but for now, as agreed shipping this.

## [1.76.0-beta.3](v1.76.0-beta.2...v1.76.0-beta.3) (2023-11-13) ### 🍕 Features * implemented the Contributions by type of contributor graph for the list activity page ([#2101](#2101)) ([0088c23](0088c23))

## [1.76.0](v1.75.0...v1.76.0) (2023-11-16) ### 🧑‍💻 Code Refactoring * remove unused components ([f71c662](f71c662)) * Replace hardcoded px value with appropriate tailwind class in Dropdown component ([#2113](#2113)) ([abf3380](abf3380)) ### 🍕 Features * add ability for user to toggle receiving email product updates ([#2133](#2133)) ([8ba0d6f](8ba0d6f)) * add params handling for new PR ([#2062](#2062)) ([b878429](b878429)) * implemented the Contributions by type of contributor graph for the list activity page ([#2101](#2101)) ([0088c23](0088c23)) * move range filter to global header ([#2047](#2047)) ([1037aef](1037aef)) * replace dashboard scatterplot chart with repositories table ([#2130](#2130)) ([dedb2e4](dedb2e4)) * select component growth enabled ([#1762](#1762)) ([3303054](3303054)) * updating last contributed column for insights table ([#2115](#2115)) ([846fdc4](846fdc4)) ### 🐛 Bug Fixes * add hovercard to most active contributors avatars in list ([#2157](#2157)) ([e02d1db](e02d1db)) * added Edit List button to all list pages ([a6a38f4](a6a38f4)) * added Edit List button to all list pages ([#2125](#2125)) ([284fa4a](284fa4a)) * added orange hearts ([#2139](#2139)) ([2b8b2ed](2b8b2ed)) * change red color to purple in merged pr bar ([#2108](#2108)) ([dc28efc](dc28efc)) * Correct wording for alumni contributors ([#2114](#2114)) ([2f23896](2f23896)) * fixed styling of delete list modal ([#2106](#2106)) ([d7d7048](d7d7048)) * h1-h6 base style using CSS from .tracking-tight ([#2142](#2142)) ([4ad69a1](4ad69a1)) * hover card now works as expected in all areas ([#2152](#2152)) ([d88f71b](d88f71b)) * insights edit repo list limit ([#2119](#2119)) ([c81e8bb](c81e8bb)) * now main index page handles redirects in middleware ([d7a69fd](d7a69fd)) * now main index page handles redirects in middleware ([#2137](#2137)) ([5b26fb2](5b26fb2)) * pr overviews in repo table now accurate ([#2118](#2118)) ([b562578](b562578)) * Remove the unused components - `CommandEmpty` and `CommandLis`t from the codebase ([#2112](#2112)) ([690738f](690738f)) * remove unnecesarry console logs ([#2151](#2151)) ([8955e02](8955e02)) * removed font-medium classes as the base style for all elements is font-medium ([#2146](#2146)) ([d06a1ca](d06a1ca)) * removed two second timeout for initial page load ([e49b799](e49b799)) * removed two second timeout for initial page load ([#2136](#2136)) ([d44248a](d44248a)) * replace hardcoded px with tailwind class ([6346cb7](6346cb7)) * replace hardcoded px with tailwind class ([6cd93ff](6cd93ff)) * show last 30 days for contribution line graphs ([#2155](#2155)) ([a1fee71](a1fee71)) * styling updates to lists of insights/lists ([947e6a5](947e6a5)) * styling updates to lists of insights/lists ([#2131](#2131)) ([34e7f92](34e7f92))

nickytonline added 6 commits November 9, 2023 22:37

chore: wip

66f4f02

chore: added a loading screen for the contributions evolution graph

8d98abb

chore: cleaned up some whitespace

08f2ffe

chore: improved responsiveness of graphs on list activity page

4a321ff

chore: cleaned up styling of chart skeleton

1f9a023

chore: added loading story to Storybook for contributions by contribu…

1db0547

…tor graph type

nickytonline force-pushed the nickytonline/contributions-evolution-by-contributor-type-graph branch from 0f637c3 to 1db0547 Compare November 10, 2023 03:37

nickytonline added 3 commits November 9, 2023 22:39

chore: removed old code

a4bc3c2

chore: now we're using an average line graph

5133af7

chore: added a comment about the average calculation

2e4ce11

nickytonline marked this pull request as ready for review November 10, 2023 15:22

chore: fixed types in ContributionsEvolutionByType Storybook story

1be4593

nickytonline force-pushed the nickytonline/contributions-evolution-by-contributor-type-graph branch from 5dea0fd to 1be4593 Compare November 10, 2023 15:30

nickytonline requested review from brandonroberts, jpmcb and OgDev-01 November 10, 2023 15:31

nickytonline commented Nov 10, 2023

View reviewed changes

components/molecules/ContributionsEvolutionByTypeCard/contributions-evolution-by-type-card.tsx Show resolved Hide resolved

components/molecules/ContributionsEvolutionByTypeCard/contributions-evolution-by-type-card.tsx Show resolved Hide resolved

jpmcb approved these changes Nov 10, 2023

View reviewed changes

OgDev-01 added the merge conflicts Needs merge conflict resolved label Nov 13, 2023

brandonroberts approved these changes Nov 13, 2023

View reviewed changes

Merge remote-tracking branch 'origin/beta' into nickytonline/contribu…

84b5eab

…tions-evolution-by-contributor-type-graph

nickytonline merged commit 0088c23 into beta Nov 13, 2023
11 checks passed

nickytonline deleted the nickytonline/contributions-evolution-by-contributor-type-graph branch November 13, 2023 16:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implemented the Contributions by type of contributor graph for the list activity page #2101

feat: implemented the Contributions by type of contributor graph for the list activity page #2101

nickytonline commented Nov 10, 2023 •

edited

Loading

netlify bot commented Nov 10, 2023 •

edited

Loading

netlify bot commented Nov 10, 2023 •

edited

Loading

nickytonline commented Nov 10, 2023

nickytonline commented Nov 10, 2023

nickytonline commented Nov 10, 2023 •

edited

Loading

jpmcb left a comment

nickytonline commented Nov 10, 2023

brandonroberts left a comment

nickytonline commented Nov 13, 2023

feat: implemented the Contributions by type of contributor graph for the list activity page #2101

feat: implemented the Contributions by type of contributor graph for the list activity page #2101

Conversation

nickytonline commented Nov 10, 2023 • edited Loading

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Nov 10, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

netlify bot commented Nov 10, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

nickytonline commented Nov 10, 2023

nickytonline commented Nov 10, 2023

nickytonline commented Nov 10, 2023 • edited Loading

jpmcb left a comment

Choose a reason for hiding this comment

nickytonline commented Nov 10, 2023

brandonroberts left a comment

Choose a reason for hiding this comment

nickytonline commented Nov 13, 2023

nickytonline commented Nov 10, 2023 •

edited

Loading

netlify bot commented Nov 10, 2023 •

edited

Loading

netlify bot commented Nov 10, 2023 •

edited

Loading

nickytonline commented Nov 10, 2023 •

edited

Loading