-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OpenSauced AI PR description #79
Conversation
I actually think we should ship with the spinner. We can make it spin when generate description is selected. Also think we can make this available on all PRs. I think a maintainer would find this useful for new contributors that don't leave descriptions. We can leave a note that says: description generated by OpenSauced |
One thing I also noticed is that the icon does not show until you are logged in, but we should show even if you are not logged in, but instead log you in when it is clicked. |
@bdougie Alright. I'll do that. |
Sorry last thing. I think we don't need to ask for an OpenAi token and can provide to add to the build or env secrets at build time. The cost for OpenSauced will be negligible and we already spent time removing friction for login. To have OpenAi tokens as more friction, it is not ideal.
Update: I invited you to the OpenSauced org on OpenAI. |
The users can see the token in the extension's network tab when a completion request is made to |
Ok let's keep it as is but make it serverside or Serverless function separately. I have solutions but we can focus on making the feature work for now. |
Yup, for what brian said to happen, we need to implement it as an opensauced API endpoint. |
I know this is still in draft, but is this testable as of yet? It doesn't seem possible to save a token in the dropdown. Or at least I don't think I can confirm if it is saved. |
I am implementing the drop-down form right now to save the config data from the form. |
@bdougie, you can try the generation now. Currently it is implemented on the "Create a pull request page". |
Just tried once and got this message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this from "AI PR Description" to "OpenSauced AI." This future proofs other AI features and we don't need to keep the scope to only PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as everything I pointed out has been addressed. @diivi brought up some valid questions and thoughts about console.error and alerts.
We should alert to assist the user journey and use the console for error messages for the developer. Let's address those, so we can merge this.
I would love to get this in @BekahHW's newsletter on Monday and @brandonroberts will assist with adding an endpoint for OpenAI so we can remove that interaction.
There's an issue I bumped into while adding the button to the "Edit PR" section. |
Seems like a reasonable solution. |
In case of draft PRs, the |
Could we disable the button with a tooltip on hover that says, "unavailable for draft prs" I was going to ask if you were going to use the feature to generate your description. That is the real test. |
But the diff is available. The commit messages are not. |
Of we can just go with diff. No need for an explanation. We can just handle it behind the scenes. |
## [1.1.0-beta.4](v1.1.0-beta.3...v1.1.0-beta.4) (2023-05-18) ### π Features * OpenSauced AI PR description ([#79](#79)) ([0e38777](0e38777))
π This PR is included in version 1.1.0-beta.4 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.1.0](v1.0.0...v1.1.0) (2023-05-20) ### π Documentation * how we create extension releases ([#81](#81)) ([10b1c48](10b1c48)) ### π Bug Fixes * add extra line and italics ([#93](#93)) ([2cbd790](2cbd790)) * update name in README ([dba4734](dba4734)) ### π Features * add/remove repos to/from insights. ([#77](#77)) ([8e4a6ed](8e4a6ed)) * OpenSauced AI PR description ([#79](#79)) ([0e38777](0e38777)) * replace open issues count with highlights count ([#76](#76)) ([0fb8149](0fb8149)) * Updated to the new AI PR description endpoint ([#94](#94)) ([cf8f64c](cf8f64c))
π This PR is included in version 1.1.0 π The release is available on GitHub release Your semantic-release bot π¦π |
## [1.1.0-beta.4](open-sauced/ai@v1.1.0-beta.3...v1.1.0-beta.4) (2023-05-18) ### π Features * OpenSauced AI PR description ([#79](open-sauced/ai#79)) ([0e38777](open-sauced/ai@0e38777))
## [1.1.0](open-sauced/ai@v1.0.0...v1.1.0) (2023-05-20) ### π Documentation * how we create extension releases ([#81](open-sauced/ai#81)) ([10b1c48](open-sauced/ai@10b1c48)) ### π Bug Fixes * add extra line and italics ([#93](open-sauced/ai#93)) ([2cbd790](open-sauced/ai@2cbd790)) * update name in README ([dba4734](open-sauced/ai@dba4734)) ### π Features * add/remove repos to/from insights. ([#77](open-sauced/ai#77)) ([8e4a6ed](open-sauced/ai@8e4a6ed)) * OpenSauced AI PR description ([#79](open-sauced/ai#79)) ([0e38777](open-sauced/ai@0e38777)) * replace open issues count with highlights count ([#76](open-sauced/ai#76)) ([0fb8149](open-sauced/ai@0fb8149)) * Updated to the new AI PR description endpoint ([#94](open-sauced/ai#94)) ([cf8f64c](open-sauced/ai@cf8f64c))
What type of PR is this? (check all applicable)
Description
This PR adds the AI PR description generation feature as suggested in #18. A new page is added to the extension dropdown to configure the description parameters. The text-generation is done using OpenAI's GPT-3.5 with the input context sourced from the code diff and/or the PR commits as configured by the user.
The feature documentation will be added to https://docs.opensauced.pizza.
Related Tickets & Documents
Resolves #18
Mobile & Desktop Screenshots/Recordings
Config window(This PR):
Config window(New OpenSauced generation endpoint, #94):
Generation demo:
Added tests?
Added to documentation?