Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove duplicate word as a contributor #164

Merged
merged 4 commits into from Oct 30, 2023
Merged

fix: Remove duplicate word as a contributor #164

merged 4 commits into from Oct 30, 2023

Conversation

BekahHW
Copy link
Member

@BekahHW BekahHW commented Oct 30, 2023

Description

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

adiati98
adiati98 previously approved these changes Oct 30, 2023
@adiati98 adiati98 self-requested a review October 30, 2023 18:28
@adiati98 adiati98 dismissed their stale review October 30, 2023 18:29

Need confirmation for merging.

@adiati98
Copy link
Member

@BekahHW is this a fix from your previous PR? If so, I'll merge it in πŸ™‚

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BekahHW

In line 19:

if: contains(github.event.pull_request.title, 'as a contributor')

Can we add the request title to also contains 'to the guestbook' as I see some folks write the title with something like "Add {name} to the guestbook"?

Copy link
Member

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CBID2
Copy link
Member

CBID2 commented Oct 30, 2023

@BekahHW, I accidentally merged this PR. πŸ€¦πŸΎβ€β™€οΈ So, I reverted it in PR #165? Can you merge that please? :)

@adiati98
Copy link
Member

adiati98 commented Oct 31, 2023

@BekahHW, I accidentally merged this PR. πŸ€¦πŸΎβ€β™€οΈ So, I reverted it in PR #165? Can you merge that please? :)

Before you merge that in, I left a comment review here for you to check out, @BekahHW πŸ™‚.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants