Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Edit this Page" link #75

Merged
merged 10 commits into from Oct 30, 2023

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 15, 2023

Description

This PR adds links to the course's pages. In doing so, contributors who want to make edits can do so quickly.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #46

Mobile & Desktop Screenshots/Recordings

image of improve this page on GitHub

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Oct 15, 2023

βœ… Deploy Preview for sauced-intro ready!

Name Link
πŸ”¨ Latest commit 71813f3
πŸ” Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/654009ce6bb7d2000889a231
😎 Deploy Preview https://deploy-preview-75--sauced-intro.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBID2 CBID2 self-assigned this Oct 15, 2023
@CBID2 CBID2 added πŸ’‘ feature hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest labels Oct 15, 2023
@CBID2 CBID2 requested a review from BekahHW October 15, 2023 20:06
01-intro.md Outdated Show resolved Hide resolved
@CBID2 CBID2 marked this pull request as draft October 18, 2023 22:30
@CBID2 CBID2 mentioned this pull request Oct 20, 2023
19 tasks
@CBID2 CBID2 changed the title feat: add "Improve this page on GitHub" link feat: add "Edit this Page" link Oct 30, 2023
@CBID2 CBID2 requested a review from BekahHW October 30, 2023 18:51
@CBID2 CBID2 marked this pull request as ready for review October 30, 2023 19:32
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CBID2
I think the understanding merge conflicts page should have a link to edit the file on GitHub too :)

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git merge GIF

@adiati98 adiati98 dismissed BekahHW’s stale review October 30, 2023 20:01

All requirements are met.

@adiati98 adiati98 merged commit f7a9056 into open-sauced:main Oct 30, 2023
4 checks passed
@CBID2 CBID2 deleted the add-edit-this-page-buttons branch October 30, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ’‘ feature hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: adding edit this page buttons
3 participants