-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: enabled vite for bundling Storybook #1473
feat: enabled vite for bundling Storybook #1473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched
- npm-shrinkwrap.json
- package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! β€οΈ! ππ
Say hello by joining the conversation in our Discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! π
Sorry for the delayed response!
|
π This PR is included in version 0.55.0 π The release is available on: Your semantic-release bot π¦π |
What type of PR is this? (check all applicable)
Description
Migrates Storybook to using vite for bundling. Some notables:
legacy-peer-depsin the .npmrc (pretty standard)jsxinstead ofjsas an extension.Take it for a test drive:
gh co 1473npm cito install new dependenciesnpm run storybook. Storybook loads just like before at http://localhost:6006Storybook & Webpack
Storybook & Vite
The key metric to look at is the preview time. Webpack still bundles the Storybook manager. So above, and it fluctuates, but with webpack only, the preview time is roughly 8 seconds, and with vite, the preview time is roughly two seconds.
Also, from my work colleague as well, and thanks for reminding me about this @kaelig:
Related Tickets & Documents
Resolves #1429
Mobile & Desktop Screenshots/Recordings
N/A
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?