Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Resolving Merge Conflicts section to the README #56

Merged
merged 3 commits into from Oct 25, 2023

Conversation

adiati98
Copy link
Member

Description

This PR adds a "Keeping Branch Up to Date and Resolving Merge Conflicts" section to the README. The purpose is to walkthrough our contributors whenever they face merge conflicts.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #31

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@adiati98 adiati98 added documentation Improvements or additions to documentation πŸ’‘ feature labels Oct 25, 2023
@adiati98 adiati98 self-assigned this Oct 25, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adiati98. You're off to a great start! :) I gave some tips on how you can improve your explanations.

@adiati98
Copy link
Member Author

@CBID2 it's ready for review! :)

Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😊

@CBID2 CBID2 merged commit 913d186 into open-sauced:main Oct 25, 2023
@adiati98 adiati98 deleted the docs/add-resolve-conflicts-section branch October 25, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation πŸ’‘ feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Change in rules
2 participants