feat(webui): support M_synth & M_train from different providers #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the web UI to support synthesizer and trainee models from different providers by updating parameter indices and UI components.
- Adjusted environment variable indices for trainee config (base URL and API key).
- Updated the relevant UI components and their callbacks to separately handle synthesizer and trainee models.
Files not reviewed (1)
- webui/translation.json: Language not supported
Comments suppressed due to low confidence (2)
webui/app.py:108
- Verify that index 20 correctly corresponds to the trainee base URL parameter and that it doesn't conflict with the synthesizer configuration.
"TRAINEE_BASE_URL": arguments[20],
webui/app.py:111
- Ensure that index 21 for the trainee API key is accurate in the context of the argument ordering, and matches the intended configuration for the trainee model.
"TRAINEE_API_KEY": arguments[21],
ChenZiHong-Gavin
pushed a commit
that referenced
this pull request
Jun 4, 2025
feat(webui): support M_synth & M_train from different providers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Also, accessing arguments via index is not convenient for subsequent maintenance (for
run_graphgenmethod). It can be considered to encapsulate them into a Config class.