Skip to content

Conversation

@ChenZiHong-Gavin
Copy link
Collaborator

@ChenZiHong-Gavin ChenZiHong-Gavin commented Sep 29, 2025

This PR adds comprehensive end-to-end (e2e) tests for the GraphGen tool, testing different output data types and standardizing the output directory structure.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds comprehensive end-to-end (e2e) tests for the GraphGen tool, testing different output data types and standardizing the output directory structure.

  • Creates e2e test files for atomic, aggregated, chain-of-thought, and multi-hop data generation
  • Modifies output path structure to include the data type in the folder name
  • Streamlines file organization by moving logs into the data directory and simplifying config file naming

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/e2e_tests/test_generate_atomic.py E2e test for atomic data generation with proper function naming
tests/e2e_tests/test_generate_aggregated.py E2e test for aggregated data generation
tests/e2e_tests/test_generate_cot.py E2e test for chain-of-thought data generation with misnamed function
tests/e2e_tests/test_generate_multi_hop.py E2e test for multi-hop data generation with misnamed function
graphgen/graphgen.py Updates output directory structure to include data type in path
graphgen/generate.py Reorganizes output structure and simplifies config file naming

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

ChenZiHong-Gavin and others added 4 commits September 29, 2025 17:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ChenZiHong-Gavin ChenZiHong-Gavin merged commit 7186cfe into main Sep 29, 2025
2 checks passed
@ChenZiHong-Gavin ChenZiHong-Gavin deleted the e2e-tests branch September 29, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants