New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonChecker tests broken #1102
Comments
A recent PR broken the JsonChecker tests by adding support for trailing commas. This didn't end up breaking the build, because those tests aren't run, except locally and only using CMake. This patch fixes the tests by adding exclusions for trailing comma tests, as well as updates Meson to run these tests as part of `ninja test`. See issue #1102.
The second kind of error is on mips64el:
Probably similar to the failure in mipsel I'm uploading in Debian the patch for this issue you proposed, I hope it fixes also the above kind of failures! |
nope, looks like the patch didn't work for my failures:
Do you have any clue? |
It seems to be all non-x86 archs. |
It should be fixed by #1120 |
I'm working on actually getting #1103 closed out, hopefully will be soon |
A recent PR broken the JsonChecker tests by adding support for trailing commas. This didn't end up breaking the build, because those tests aren't run, except locally and only using CMake. This patch fixes the tests by adding exclusions for trailing comma tests, as well as updates Meson to run these tests as part of `ninja test`. See issue #1102.
@LocutusOfBorg, it's definitely important for tests to pass in parallel. We'll try to get to that for the upcoming release. |
A recent PR broken the JsonChecker tests by adding support for trailing commas. This didn't end up breaking the build, because those tests aren't run, except locally and only using CMake. This patch fixes the tests by adding exclusions for trailing comma tests, as well as updates Meson to run these tests as part of `ninja test`. See issue #1102.
A recent PR broken the JsonChecker tests by adding support for trailing commas. This didn't end up breaking the build, because those tests aren't run, except locally and only using CMake. This patch fixes the tests by adding exclusions for trailing comma tests, as well as updates Meson to run these tests as part of `ninja test`. See issue #1102.
Fixed for meson. No idea about cmake, but when we reorganize the test-suite we might address that. |
After the recent trailing commas change, json checker tests aren't broken.
A fix means making these tests run as part of checkin again, and resolving the actual test failures as well.
The text was updated successfully, but these errors were encountered: