feat: use predicted manifest update time to determine when to refetch #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-cochran
commented
Nov 2, 2023
vishwa2710
approved these changes
Nov 3, 2023
kyle-cochran
force-pushed
the
users/kyle/manifest-update-limit
branch
from
d0a4204
to
efee1e4
Compare
apaletta3
approved these changes
Nov 6, 2023
Co-authored-by: Vishwa Shah <vishwa2710@gmail.com>
* refactor: remove unused in-memory caches from IERS data manager * test: mock the fetch from manifest test * test: fix IERS test load expecation * build: add gmock linking to CMakeLists * refactor: change get*At methods to get* and update bindings * chore: remove test references to old methods * fix: bug in BulletinA loader that loaded observation data as prediction * test: fix expectations for test reset test functions since the getters auto-fetch * test: fix expectations for test reset test functions since the getters auto-fetch * style: formatting * test: make file age test portable * feat: add constness to mutex-protected functions * refactor: rename IERS Manager private functions with underscores for clarity * style: re-order IERS manager functions * refactor: add suggestions from code review * feat: Manifest Manager thread safety * style: formatting * test: update mock to match new function name
kyle-cochran
force-pushed
the
users/kyle/manifest-update-limit
branch
from
d7ee04e
to
f6bebc1
Compare
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 80.00% 80.18% +0.18%
==========================================
Files 93 94 +1
Lines 7460 7458 -2
==========================================
+ Hits 5968 5980 +12
+ Misses 1492 1478 -14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline passing depends on the associated OSTk Data MR being merged:
open-space-collective/open-space-toolkit-data#6
Uses the "manifest" entry in the manifest to predict when the remote will have updated data and waits until then to poll for a new manifest file, rather than doing it every time.