Proposal: Go Compile Time Instrumentation SIG#2490
Proposal: Go Compile Time Instrumentation SIG#2490danielgblanco merged 7 commits intoopen-telemetry:mainfrom
Conversation
ralf0131
requested review from
alolita,
austinlparker,
danielgblanco,
jpkrohling,
mtwo,
mx-psi,
svrnm,
tedsuo and
trask
as code owners
ralf0131
force-pushed
the
main
branch
2 times, most recently
from
b5906f5 to
2f8081e
Compare
danielgblanco
added
the
area/project-proposal
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
|
I approve! |
1 similar comment
|
I approve! |
|
@123liuziming @NameHaibinZhang @y1yang0 can you please review the changes and approve it if it looks good to you (instead of only leaving a comment)? thanks |
Sorry, I do not realize that I have the access to approve, thanks! |
jpkrohling
left a comment
jpkrohling
left a comment
There was a problem hiding this comment.
my comment/suggestion isn't blocking, I'm happy to sponsor this SIG!
|
Should this project proposal include mentions of the two donation proposals that will be considered as part of this work? The one from Alibaba in #2344 and Datadog in #2497 I think it's awesome that we can get the best learnings from each and provide the community with a unified approach. Would love to see it reflected here. |
How about adding the following content to the end of the proposal ReferenceThe project is a joint effort of donation proposal coming from Alibaba and Datadog. The proposals are listed as follows: |
|
I think that'd be great @ralf0131 |
All the suggestion are applied. |
I think, we could also mention that goal is also to replace https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrgen |
Sure. How about this? The project is a joint effort of donation proposal coming from Alibaba and Datadog to replace Instrgen. The proposals are listed as follows: |
fixed in #2503 and merged latest into your branch, should be fixed now |
|
@danielgblanco @pdelewski Thanks for the comments, the proposed change has been committed. All the pending issues are cleared. |
|
This project now has 5 approvals from GC members, so ready to start! Merging. |
|
|
||
| Additionally, the following people will participate in the SIG and be added as approvers once they are OpenTelemetry Github org members: | ||
|
|
||
| - Future Approvers: @yiyang0(Alibaba Cloud), @123liuziming(Alibaba Cloud), @RomainMuller(Datadog) |
There was a problem hiding this comment.
Use Alibaba here? we have all used the affiliated name.
There was a problem hiding this comment.
Good catch! I will update it together with the project board.
15 participants
This is a proposal to establish the Go compile time instrumentation SIG. The background has been discussed in #1961. A consensus has been reached among GC/TC members, Go maintainers and multiple interested vendors.
We believe that the Go Compile Time Instrumentation SIG ensures that Go applications benefit from standardized, vendor-neutral, high-quality observability solutions that are both robust and easy to implement. Having one single, standard tool removes decision points from prospective developers, which makes the path to observability shorter & easier.