diff --git a/exporter/opentelemetry-exporter-zipkin/CHANGELOG.md b/exporter/opentelemetry-exporter-zipkin/CHANGELOG.md index 1d03ea25c5b42..562e5cc1248e8 100644 --- a/exporter/opentelemetry-exporter-zipkin/CHANGELOG.md +++ b/exporter/opentelemetry-exporter-zipkin/CHANGELOG.md @@ -15,8 +15,6 @@ Released 2020-09-17 ([#1097](https://github.com/open-telemetry/opentelemetry-python/pull/1097)) - Drop support for Python 3.4 ([#1099](https://github.com/open-telemetry/opentelemetry-python/pull/1099)) -- Add status mapping to tags - ([#1111](https://github.com/open-telemetry/opentelemetry-python/issues/1111)) ## Version 0.12b0 diff --git a/exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py b/exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py index 1e544bcdac2f7..8c3c91a6d3c20 100644 --- a/exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py +++ b/exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py @@ -183,15 +183,6 @@ def _translate_to_zipkin(self, spans: Sequence[Span]): "otel.instrumentation_library.version" ] = span.instrumentation_info.version - if span.status is not None: - zipkin_span["tags"][ - "otel.status_code" - ] = span.status.canonical_code.value - if span.status.description is not None: - zipkin_span["tags"][ - "otel.status_description" - ] = span.status.description - if context.trace_flags.sampled: zipkin_span["debug"] = True diff --git a/exporter/opentelemetry-exporter-zipkin/tests/test_zipkin_exporter.py b/exporter/opentelemetry-exporter-zipkin/tests/test_zipkin_exporter.py index 49d1c2ffe62c0..309d9668057fb 100644 --- a/exporter/opentelemetry-exporter-zipkin/tests/test_zipkin_exporter.py +++ b/exporter/opentelemetry-exporter-zipkin/tests/test_zipkin_exporter.py @@ -24,7 +24,6 @@ from opentelemetry.sdk.trace.export import SpanExportResult from opentelemetry.sdk.util.instrumentation import InstrumentationInfo from opentelemetry.trace import TraceFlags -from opentelemetry.trace.status import Status, StatusCanonicalCode class MockResponse: @@ -175,9 +174,6 @@ def test_export(self): otel_spans[0].set_attribute("key_bool", False) otel_spans[0].set_attribute("key_string", "hello_world") otel_spans[0].set_attribute("key_float", 111.22) - otel_spans[0].set_status( - Status(StatusCanonicalCode.UNKNOWN, "Example description") - ) otel_spans[0].end(end_time=end_times[0]) otel_spans[1].start(start_time=start_times[1]) @@ -217,8 +213,6 @@ def test_export(self): "key_bool": "False", "key_string": "hello_world", "key_float": "111.22", - "otel.status_code": 2, - "otel.status_description": "Example description", }, "annotations": [ { @@ -237,10 +231,7 @@ def test_export(self): "duration": durations[1] // 10 ** 3, "localEndpoint": local_endpoint, "kind": None, - "tags": { - "key_resource": "some_resource", - "otel.status_code": 0, - }, + "tags": {"key_resource": "some_resource"}, "annotations": None, }, { @@ -254,7 +245,6 @@ def test_export(self): "tags": { "key_string": "hello_world", "key_resource": "some_resource", - "otel.status_code": 0, }, "annotations": None, }, @@ -269,7 +259,6 @@ def test_export(self): "tags": { "otel.instrumentation_library.name": "name", "otel.instrumentation_library.version": "version", - "otel.status_code": 0, }, "annotations": None, }, @@ -335,7 +324,7 @@ def test_zero_padding(self): "duration": duration // 10 ** 3, "localEndpoint": local_endpoint, "kind": None, - "tags": {"otel.status_code": 0}, + "tags": {}, "annotations": None, "debug": True, "parentId": "0aaaaaaaaaaaaaaa",