[datadogexporter] Use a singleton for sublayer calculation #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, we would use one sublayer calculator per worker as the Datadog Agent does, but we can't here since we don't have access to the queue consumers.
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 376 376
Lines 18180 18184 +4
=======================================
+ Hits 16336 16340 +4
Misses 1383 1383
Partials 461 461
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ericmustin
approved these changes
Dec 4, 2020
bogdandrutu
reviewed
Dec 7, 2020
exporter/datadogexporter/stats.go
Outdated
| @@ -26,8 +26,7 @@ const ( | |||
| ) | |||
|
|
|||
| // ComputeAPMStats calculates the stats that should be submitted to APM about a given trace | |||
| func ComputeAPMStats(tracePayload *pb.TracePayload, calculator *stats.SublayerCalculator, pushTime int64) *stats.Payload { | |||
|
|
|||
| func ComputeAPMStats(tracePayload *pb.TracePayload, calculator *sublayerCalculator, pushTime int64) *stats.Payload { | |||
There was a problem hiding this comment.
I was trying to maintain the visibility of existing functions that were already public. I have double checked with the person who wrote this code and these and other functions can be made private, so I have done so in commit 1345a4d.
I can also make these changes in a separate PR if need be.
bogdandrutu
approved these changes
Dec 11, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
…er (#1759) * add test to cover default configurations; update document for default max_elapsed_time value * check type assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: aws-observability/aws-otel-collector#179
Testing: Unit tests were amended. Tested end to end and performance tested.