[WIP] Multi-architecture container images #2397
Conversation
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
| steps: | ||
| - run: | ||
| name: Install Docker buildx |
There was a problem hiding this comment.
Oh forgot this was still circleci, doh!
| docker build -t $(COMPONENT) ./cmd/$(COMPONENT)/ | ||
| rm ./cmd/$(COMPONENT)/$(COMPONENT) | ||
| cp ./bin/$(COMPONENT)_linux_amd64 ./cmd/$(COMPONENT) | ||
| docker build -t $(COMPONENT) ./cmd/$(COMPONENT)/ --build-arg=TARGETOS=linux --build-arg=TARGETARCH=amd64 |
There was a problem hiding this comment.
Is it simpler to use buildx for this too so we don't need to define the args?
There was a problem hiding this comment.
My opinion at this time is to make the multi-architecture build additive and not require buildx for all contributors. Since 'make docker-otelcontribcol' is pre-existing, I believe it should continue to work without contributors updating their tooling. If contributors want to build multi-arch images, then they'll need to install buildx (doesn't seem common at this time).
Maybe after we have buildx working as expected in the CI/CD pipeline and are okay with requiring contributors to install an experimental tool, then we can fully migrate to buildx. I'm hoping that buildx will be fully baked into Docker this year, so it will become a natural progression.
gramidt
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
* [website_docs] Link to website page via path Contributes to open-telemetry/opentelemetry.io#922. /cc @austinlparker * Make links relative and wrap paragraph text Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Description:
Update CI/CD to build multi-architecture container images. Currently multiple binaries are created for OS/architectures; however, only a single container image is created (linux/amd64). This PR will build and push both linux/amd64 and linux/arm64 container images and setup the foundation to make it trivial to build additional architecture images in the future.
Link to tracking Issue:
#2379
Testing:
TODO
Documentation:
TODO