Signalfx exporter: reduce memory allocations for big batches processing #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
sfxexporter-alloc-optimize
branch
from
8a8fb32
to
b68c2ea
Compare
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 233 233
Lines 12395 12396 +1
=======================================
+ Hits 10934 10935 +1
Misses 1111 1111
Partials 350 350
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dmitryax
force-pushed
the
sfxexporter-alloc-optimize
branch
from
b68c2ea
to
02573a9
Compare
bogdandrutu
reviewed
Aug 31, 2020
Enabling batching causes many extra allocations in signalfx exporter. This change reduces allocations of []*sfxpb.DataPoint slices by pre-initializing []*sfxpb.DataPoint slice for the whole batch. Benchmark test on a 1000 metrics batch: BEFORE: Running tool: /usr/local/bin/go test -benchmem -run=^$ -bench ^(BenchmarkExporterConsumeData)$ goos: darwin goarch: amd64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter BenchmarkExporterConsumeData-12 78 14264799 ns/op 6911068 B/op 70208 allocs/op PASS ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter 1.896s AFTER: Running tool: /usr/local/bin/go test -benchmem -run=^$ -bench ^(BenchmarkExporterConsumeData)$ goos: darwin goarch: amd64 pkg: github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter BenchmarkExporterConsumeData-12 93 12466935 ns/op 6429209 B/op 68854 allocs/op PASS ok github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter 1.897s
dmitryax
force-pushed
the
sfxexporter-alloc-optimize
branch
from
02573a9
to
988ea3f
Compare
bogdandrutu
approved these changes
Aug 31, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
…871) Transitive dependency changes sometimes do require a change to go.mod files as well as go.sum. This is already live in the opentelemetry-go-contrib repo, and this PR brings it here.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
The trailing_metadata method was added to grpc._server.ServicerContext in gRPC v1.38.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enabling batching causes many extra allocations in signalfx exporter. This change reduces allocations of []*sfxpb.DataPoint slices by pre-initializing []*sfxpb.DataPoint slice for the whole batch.
Testing:
Benchmark test on a 1000 metrics batch:
BEFORE:
AFTER: