[Instrumentation.Runtime] Update OTel API version to `1.4.0-beta.2` and change runtime metrics type to ObservableUpDownCounter #675

xiang17 · 2022-10-04T23:07:23Z

Update OTel API version to 1.4.0-beta.2 and change runtime metrics type to ObservableUpDownCounter now that it's ready. (Released in 1.4.0-beta.1: https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.4.0-beta.1)

For significant contributions please make sure you have completed the following items:

Appropriate CHANGELOG.md updated for non-trivial changes
Design discussion issue #

…ready

codecov · 2022-10-05T01:44:13Z

Codecov Report

Merging #675 (967011e) into main (52585a1) will not change coverage.
The diff coverage is 85.71%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   77.74%   77.74%           
=======================================
  Files         176      176           
  Lines        5343     5343           
=======================================
  Hits         4154     4154           
  Misses       1189     1189

Impacted Files	Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs	`85.10% <85.71%> (ø)`

Kielek

I have doubts if the beta version should be included into the contrib.
The changes does not looks huge and probably could be included together with 1.4.0 release.

src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md

Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>

xiang17 · 2022-10-05T18:22:49Z

I have doubts if the beta version should be included into the contrib. The changes does not looks huge and probably could be included together with 1.4.0 release.

I have similar doubts on how to integrate beta version. If there happen to be any changes needed for the stable version, we'd need to create a branch from a past commit and maintain two branches. However, there are some benefits for doing it early:

More changes coming to this PR to upgrade to 1.4.0, because netcoreapp3.1 should be removed. I need to remove netcoreapp3.1 in TargetFrameworks, and potentially in GitHub actions. Refer to warnings in the build:

/home/runner/.nuget/packages/system.diagnostics.diagnosticsource/7.0.0-rc.1.22426.10/buildTransitive/netcoreapp2.0/System.Diagnostics.DiagnosticSource.targets(4,5): warning : System.Diagnostics.DiagnosticSource 7.0.0-rc.1.22426.10 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk. [/home/runner/work/opentelemetry-dotnet-contrib/opentelemetry-dotnet-contrib/src/OpenTelemetry.Instrumentation.Runtime/OpenTelemetry.Instrumentation.Runtime.csproj]
/home/runner/.nuget/packages/system.diagnostics.diagnosticsource/7.0.0-rc.1.22426.10/buildTransitive/netcoreapp2.0/System.Diagnostics.DiagnosticSource.targets(4,5): warning : System.Diagnostics.DiagnosticSource 7.0.0-rc.1.22426.10 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk. [/home/runner/work/opentelemetry-dotnet-contrib/opentelemetry-dotnet-contrib/test/OpenTelemetry.Instrumentation.Runtime.Tests/OpenTelemetry.Instrumentation.Runtime.Tests.csproj]

Early access to anyone who needs to test/preview/integrate with the UpDownCounter or OTel 1.4.0 version.

@utpilla Do you have any suggestion? Especially for removing netcoreapp3.1 in Github action, it may apply to all projects in this repo.

cijothomas · 2022-10-05T18:32:15Z

I have doubts if the beta version should be included into the contrib. The changes does not looks huge and probably could be included together with 1.4.0 release.

Each component can chose the version they want. We have no reason to prevent any component from moving to a newer version.

src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md

cijothomas · 2022-10-05T23:28:38Z

src/OpenTelemetry.Instrumentation.Runtime/RuntimeMetrics.cs

@@ -90,8 +89,7 @@ static RuntimeMetrics()
        // Either Environment.Version is not 6 or (it's 6 but internal API GC.GetGenerationSize is valid)
        if (!isCodeRunningOnBuggyRuntimeVersion || getGenerationSize != null)
        {
-            // TODO: change to ObservableUpDownCounter
-            MeterInstance.CreateObservableGauge(
+            MeterInstance.CreateObservableUpDownCounter(


Do you think this is a breaking change? For sure OTLP Exporters see dif. data type now, but exporter like Prometheus would be fine...
@alanwest Can you check from NR stand point, if this will be breaking for anyone sending to NR via OTLP?

Apologies for delay. No this is not breaking for New Relic. NR has its own gauge data type. Both OTLP gauges and OTLP non-monotonic sums are transformed to a NR gauge, so there will be no difference for end users querying this data in NR.

Though, it may be possible this could be breaking for other backends.

We can bring this to the next SIG to make a call about do we need to major version bump or not.

@lachmatt checked changes with Splunk OTLP endpoint and it is working correctly.

BTW I would consider it as a bugfix not a breaking change. There were no possibility to set it correctly with older dependencies.

github-actions · 2022-10-18T04:02:37Z

This PR was marked stale due to lack of activity. It will be closed in 7 days.

…`1.4.0-beta.2`

cijothomas · 2022-10-21T17:14:42Z

src/OpenTelemetry.Instrumentation.Runtime/README.md

@@ -301,6 +297,23 @@ metric is available in the .NET version you are running.
 Some GC related metrics are unavailable until at least one garbage collection
 has occurred.

+## Note


do we need it here?

cijothomas

changes look good!
Based on most comments I am proposing to release this as minor version bump only. But will discuss this in next SIG meeting to finalize. (Stable cannot anyway occur before 1.4.0 of the API itself is stable, expected November 2022)

Change runtime metrics type to ObservableUpDownCounter now that it's …

6ac022c

…ready

xiang17 requested a review from a team October 4, 2022 23:07

github-actions bot assigned xiang17 Oct 4, 2022

xiang17 added 4 commits October 4, 2022 16:08

update CHANGELOG.md

9b4a647

Revert version update for Common.props and only update csproj of Runtime

d2412c0

Update OpenTelemetry.Exporter.InMemory version for test project

51b06b5

Merge branch 'main' into xiang17/UpDownCounter

f976d8e

Kielek reviewed Oct 5, 2022

View reviewed changes

src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md Outdated Show resolved Hide resolved

Update src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md

6adcb55

Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>

Merge branch 'main' into xiang17/UpDownCounter

2687a10

utpilla reviewed Oct 5, 2022

View reviewed changes

src/OpenTelemetry.Instrumentation.Runtime/CHANGELOG.md Outdated Show resolved Hide resolved

cijothomas reviewed Oct 5, 2022

View reviewed changes

utpilla added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Oct 10, 2022

utpilla changed the title ~~Update OTel API version to 1.4.0-beta.1 and change runtime metrics type to ObservableUpDownCounter~~ [Instrumentation.Runtime] Update OTel API version to 1.4.0-beta.1 and change runtime metrics type to ObservableUpDownCounter Oct 10, 2022

github-actions bot added Stale and removed Stale labels Oct 18, 2022

xiang17 added 2 commits October 20, 2022 14:11

Update OpenTelemetry.Exporter.InMemory and OpenTelemetry.Api to …

b6ab210

…`1.4.0-beta.2`

Merge branch 'main' into xiang17/UpDownCounter

1f08752

xiang17 changed the title ~~[Instrumentation.Runtime] Update OTel API version to 1.4.0-beta.1 and change runtime metrics type to ObservableUpDownCounter~~ [Instrumentation.Runtime] Update OTel API version to 1.4.0-beta.2 and change runtime metrics type to ObservableUpDownCounter Oct 20, 2022

xiang17 added 4 commits October 20, 2022 14:26

markdown sanity check

d71956d

reword changelog

e90b715

Merge branch 'main' into xiang17/UpDownCounter

ab1bcdf

reword changelog

5e6bdf8

cijothomas reviewed Oct 21, 2022

View reviewed changes

cijothomas approved these changes Oct 21, 2022

View reviewed changes

Merge branch 'main' into xiang17/UpDownCounter

0af9835

Merge branch 'main' into xiang17/UpDownCounter

967011e

cijothomas merged commit bb9462c into open-telemetry:main Oct 21, 2022

xiang17 deleted the xiang17/UpDownCounter branch November 22, 2022 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Instrumentation.Runtime] Update OTel API version to `1.4.0-beta.2` and change runtime metrics type to ObservableUpDownCounter #675

[Instrumentation.Runtime] Update OTel API version to `1.4.0-beta.2` and change runtime metrics type to ObservableUpDownCounter #675

xiang17 commented Oct 4, 2022 •

edited

Loading

codecov bot commented Oct 5, 2022 •

edited

Loading

Kielek left a comment

xiang17 commented Oct 5, 2022

cijothomas commented Oct 5, 2022

cijothomas Oct 5, 2022

alanwest Oct 19, 2022

cijothomas Oct 20, 2022

Kielek Oct 21, 2022

Kielek Oct 21, 2022

github-actions bot commented Oct 18, 2022

cijothomas Oct 21, 2022

cijothomas left a comment

[Instrumentation.Runtime] Update OTel API version to 1.4.0-beta.2 and change runtime metrics type to ObservableUpDownCounter #675

[Instrumentation.Runtime] Update OTel API version to 1.4.0-beta.2 and change runtime metrics type to ObservableUpDownCounter #675

Conversation

xiang17 commented Oct 4, 2022 • edited Loading

codecov bot commented Oct 5, 2022 • edited Loading

Codecov Report

Kielek left a comment

Choose a reason for hiding this comment

xiang17 commented Oct 5, 2022

cijothomas commented Oct 5, 2022

cijothomas Oct 5, 2022

Choose a reason for hiding this comment

alanwest Oct 19, 2022

Choose a reason for hiding this comment

cijothomas Oct 20, 2022

Choose a reason for hiding this comment

Kielek Oct 21, 2022

Choose a reason for hiding this comment

Kielek Oct 21, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 18, 2022

cijothomas Oct 21, 2022

Choose a reason for hiding this comment

cijothomas left a comment

Choose a reason for hiding this comment

[Instrumentation.Runtime] Update OTel API version to `1.4.0-beta.2` and change runtime metrics type to ObservableUpDownCounter #675

[Instrumentation.Runtime] Update OTel API version to `1.4.0-beta.2` and change runtime metrics type to ObservableUpDownCounter #675

xiang17 commented Oct 4, 2022 •

edited

Loading

codecov bot commented Oct 5, 2022 •

edited

Loading