From 39d960e0e77aa81c022bda0b33e1d23cf93a9f2d Mon Sep 17 00:00:00 2001 From: Mikel Blanchard Date: Fri, 29 Mar 2024 12:01:21 -0700 Subject: [PATCH] [docs-traces] Added version info to the OTEL_TRACES_SAMPLER doc (#5492) --- docs/trace/customizing-the-sdk/README.md | 4 ++-- src/OpenTelemetry/Trace/TracerProviderSdk.cs | 7 +------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/docs/trace/customizing-the-sdk/README.md b/docs/trace/customizing-the-sdk/README.md index 01db0f6fd6..d78ed1cd56 100644 --- a/docs/trace/customizing-the-sdk/README.md +++ b/docs/trace/customizing-the-sdk/README.md @@ -363,8 +363,8 @@ var tracerProvider = Sdk.CreateTracerProviderBuilder() .Build(); ``` -It is also possible to configure the sampler by using the following -environmental variables: +If using `1.8.0-rc.1` or newer it is also possible to configure the sampler by +using the following environmental variables: | Environment variable | Description | | -------------------------- | -------------------------------------------------- | diff --git a/src/OpenTelemetry/Trace/TracerProviderSdk.cs b/src/OpenTelemetry/Trace/TracerProviderSdk.cs index fc3fe02631..2da7f0ea4d 100644 --- a/src/OpenTelemetry/Trace/TracerProviderSdk.cs +++ b/src/OpenTelemetry/Trace/TracerProviderSdk.cs @@ -407,12 +407,7 @@ protected override void Dispose(bool disposing) private static Sampler GetSampler(IConfiguration configuration, Sampler? stateSampler) { - Sampler? sampler = null; - - if (stateSampler != null) - { - sampler = stateSampler; - } + var sampler = stateSampler; if (configuration.TryGetStringValue(TracesSamplerConfigKey, out var configValue)) {